Skip to content

Conversation

@Arsalanulhaq
Copy link
Contributor

No description provided.

@Arsalanulhaq Arsalanulhaq marked this pull request as draft January 13, 2026 12:49
@Arsalanulhaq Arsalanulhaq force-pushed the as/dev/update_template branch from 586f04c to 558f9a0 Compare January 13, 2026 13:40
@Arsalanulhaq Arsalanulhaq force-pushed the as/dev/update_template branch from 558f9a0 to 3640bdc Compare January 13, 2026 13:41
@Arsalanulhaq Arsalanulhaq force-pushed the as/dev/update_template branch from 6dfd2e1 to 8a4599a Compare January 13, 2026 15:50
@Arsalanulhaq Arsalanulhaq changed the title refactor: rename app_template to ncw_apps_menu across all relevant files ncw_tools: Initial app version Jan 14, 2026
@Arsalanulhaq Arsalanulhaq force-pushed the as/dev/update_template branch 2 times, most recently from fe5b75c to ee0e445 Compare January 14, 2026 11:29
@Arsalanulhaq Arsalanulhaq marked this pull request as ready for review January 14, 2026 16:04
@printminion-co printminion-co self-requested a review January 14, 2026 16:18
Copy link
Collaborator

@printminion-co printminion-co left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review ok if proposed fixup commits on top are adrressed

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR represents the initial version of the NCW Tools app, transitioning from an app template to a utility application. The app now provides event listeners and extensible tools for system administration and maintenance tasks in Nextcloud environments.

Changes:

  • Renamed application from app_template to ncw_tools across all configuration and code files
  • Removed frontend components (Vue.js, Vite, npm dependencies) to focus on backend-only functionality
  • Added comprehensive REUSE licensing configuration and license files for compliance
  • Updated CI/CD workflows with newer action versions and configurations specific to backend-only testing

Reviewed changes

Copilot reviewed 44 out of 48 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
lib/AppInfo/Application.php Updated namespace and app ID constant to reflect new app name
appinfo/info.xml Changed app metadata including ID, name, description, author, and removed navigation entries
composer.json Updated package name and namespace mappings
tests/unit/AppInfo/ApplicationTest.php Added comprehensive test suite for Application class
tests/bootstrap.php Updated app reference in bootstrap loader
REUSE.toml Added comprehensive licensing configuration for all file types
README.md Replaced template instructions with actual app documentation
.github/workflows/* Updated workflow files with newer action versions and backend-focused configuration
Various frontend files Removed all Vue.js, TypeScript, and npm-related files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Arsalanulhaq and others added 20 commits January 15, 2026 13:13
Added detailed instructions for developers on using Copilot and guidelines for writing Git commit messages. This aims to standardize practices across the project and improve collaboration.

The new files include:
- `copilot-instructions.md`: Project-wide Copilot instructions for all developers.
- `git-commit-instructions.md`: Quick reference for Git commit message guidelines.

These documents provide essential context, repository structure, and best practices to enhance the development workflow.
Update .gitignore to exclude the coverage directory from version control, ensuring cleaner repository management.
Updated the test suite name in phpunit.xml to better reflect the project's purpose.
Added unit tests to verify the Application class functionality, including
checks for the APP_ID constant, constructor initialization, and the
existence of the register method. This enhances test coverage and
ensures the Application class behaves as expected.

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
@Arsalanulhaq Arsalanulhaq merged commit 3af182e into main Jan 15, 2026
29 checks passed
@Arsalanulhaq Arsalanulhaq deleted the as/dev/update_template branch January 15, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants