Disable mailing (cherry picked upstream PR) #49
Conversation
thlehmann-ionos
changed the title
thlehmann-ionos
force-pushed
the
tl/dev/disable-mailing-cherry-picked
branch
from
fcccc0f to
0519937
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
thlehmann-ionos
force-pushed
the
tl/dev/disable-mailing-cherry-picked
branch
from
0519937 to
c9d9ffa
Compare
|
Upstream PR nextcloud#48977 got accepted. Final commits cherry-picked here. |
|
Needs config: IONOS-Productivity/nc-config#32 |
thlehmann-ionos
force-pushed
the
tl/dev/disable-mailing-cherry-picked
branch
from
c9d9ffa to
1de00e3
Compare
Currently $this->instance is never set, so the code is no-op. This brings back caching of the instance. Caching broke with be7db15 Swift to \Swift_Mailer as abstraction Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
The IDE hinted the value is immediately overwritten. Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
printminion-co
force-pushed
the
tl/dev/disable-mailing-cherry-picked
branch
from
1de00e3 to
f21f9c9
Compare
== Goal Allow disabling mail delivery altogether. == Usecase If mails ought to be send by other means than rendering messages from templates and sending them via SMTP-like protocols. Example: listening to specific Nextcloud events and pass parameters to a centralized (i.e. REST-based) API that sends e-mails. Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
When the mail transport is configured as null transport, the configuration UI would not work. == Background The null transport is meant for situations where operators implement mail delivery via custom mechanisms like REST APIs. Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
printminion-co
force-pushed
the
tl/dev/disable-mailing-cherry-picked
branch
from
f21f9c9 to
969055b
Compare
There was a problem hiding this comment.
review ok.. ..jus changed the " on ' in two file in order to be same with nextcloud#48977
Upstream PR: nextcloud#48977
Approach discussed with Louis Chemineau.
Summary
If mails ought to be send by other means than rendering messages from
templates and sending them via SMTP-like protocols.
Use-case example
Listening to specific Nextcloud events and pass parameters to a centralized (i.e. REST-based) API that sends e-mails.
Background why not ...
mail_template_class: same as beforeBeforeMessageSentand act upon that: would be an option, but it would still render messages that will never be sent and the template data might also have to be enriched with custom information (i.e. in our case the sender's user ID, not their e-mail address)