[Review] Fix view action for shares (legacy, simplified) #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2025
…acy) Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
tanyaka
force-pushed
the
tkl/fb/dev/fix-view-action-shares
branch
from
958ee2f to
1ed6885
Compare
…n menu Signed-off-by: Franziska Bath <franziska.bath@strato.de> Co-authored-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de> Co-authored-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
Signed-off-by: Franziska Bath <franziska.bath@strato.de> Co-authored-by:Signed-off-by: Tatjana Kaschperko Lindt <kaschperko-lindt@strato.de>
printminion-co
force-pushed
the
tkl/fb/dev/fix-view-action-shares
branch
from
1ed6885 to
ed8f6cc
Compare
printminion-co
approved these changes
May 12, 2025
There was a problem hiding this comment.
- I think there is no need to add the viewer icon for context menu since it is not displayed by NC for images by default 🤷. (to late - I've merged the viewer code)
- moved the "dir" logic to own block for better readability/future merge problems
- switched to usage of
self._context.$file.attr('data-type') === 'dir'as it was made by NC in code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO