-
Notifications
You must be signed in to change notification settings - Fork 70
feat: Changed the constants to variables under account/settings reopened
#1297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
prasadtalasila
merged 31 commits into
INTO-CPS-Association:feature/distributed-demo
from
atomicgamedeveloper:feature/distributed-demo
Sep 5, 2025
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
78d7489
feat: Changed the constants to variables under `account/settings`
Microchesst 0ce26dd
Migrate codeclimate to qlty (#1254)
prasadtalasila 9782521
Split pipeline utilities into focused modules (#1272 and #1277)
prasadtalasila e5cb86d
Fix malfunctioning tests
atomicgamedeveloper 536b601
Change Account content
atomicgamedeveloper 84080ca
Fix conflicting branch actions
atomicgamedeveloper 3f5f039
Highten element precision in e2e test for lower error proneness
atomicgamedeveloper 445453a
Rebase settings PR code
atomicgamedeveloper b3fbb75
Merge branch 'feature/distributed-demo' of https://github.com/atomicg…
atomicgamedeveloper c3f8ebd
Let user change common library project name
atomicgamedeveloper c95f6ab
Add part of tests and fix some minor issues
atomicgamedeveloper 2cfa3a0
Address code quality problems and add more tests
atomicgamedeveloper 822174f
Add basic e2e settings test suite
atomicgamedeveloper 1540b27
Formatting
atomicgamedeveloper fb13420
Fix broken test
atomicgamedeveloper 8c3a6ef
Refactor constants.ts into digitalTwinConfig/settingsUtil.ts and digi…
atomicgamedeveloper 1072a71
Cover remaining lines
atomicgamedeveloper 7f731af
Rm duplicate test case
atomicgamedeveloper 2d1b244
Minor improvements to tests
atomicgamedeveloper ce98de5
Add branch to settings, fix other review issues
atomicgamedeveloper 4c60fea
Refactor: Update imports and file types across the project
atomicgamedeveloper fde0cfe
Move constants tests to digitalTwinConfig/settingsUtility.test.tsx, u…
atomicgamedeveloper f8f1d31
Update import paths for utility interfaces in GitlabAPI and GitlabIns…
atomicgamedeveloper 24e78fb
Disable cache for jest tests
atomicgamedeveloper f35690b
Rename utilityInterfaces properly
atomicgamedeveloper be96710
Refactor tests to remove unnecessary jest.clearAllMocks() calls
atomicgamedeveloper e22bd06
Formatting
atomicgamedeveloper fd6f794
Last line coverage
atomicgamedeveloper e4cafe8
Reorganize interfaces, fix mocking problem
atomicgamedeveloper 3753d60
Remove unnecessary type aliases for JobName and LogContent in executi…
atomicgamedeveloper 1df49ab
Bump version to 0.9.0 in package.json
atomicgamedeveloper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file was deleted.
Oops, something went wrong.
29 changes: 29 additions & 0 deletions
29
client/src/model/backend/gitlab/digitalTwinConfig/constants.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import { FileType } from 'model/backend/interfaces/sharedInterfaces'; | ||
|
|
||
| // Default project settings | ||
| export const GROUP_NAME = 'DTaaS'; | ||
| export const DT_DIRECTORY = 'digital_twins'; | ||
| export const COMMON_LIBRARY_PROJECT_NAME = 'common'; | ||
| export const RUNNER_TAG = 'linux'; | ||
| export const BRANCH_NAME = 'master'; | ||
|
|
||
| // Pipeline execution settings | ||
| export const MAX_EXECUTION_TIME = 10 * 60 * 1000; | ||
| export const PIPELINE_POLL_INTERVAL = 5 * 1000; | ||
|
|
||
| // Maps tabs to project folders (based on asset types) | ||
| export enum AssetTypes { | ||
| 'Functions' = 'functions', | ||
| 'Models' = 'models', | ||
| 'Tools' = 'tools', | ||
| 'Data' = 'data', | ||
| 'Digital Twins' = 'digital_twins', | ||
| 'Digital Twin' = 'digital_twin', | ||
| } | ||
|
|
||
| // Default initial files for new digital twins | ||
| export const defaultFiles = [ | ||
| { name: 'description.md', type: FileType.DESCRIPTION }, | ||
| { name: 'README.md', type: FileType.DESCRIPTION }, | ||
| { name: '.gitlab-ci.yml', type: FileType.CONFIGURATION }, | ||
| ]; |
17 changes: 17 additions & 0 deletions
17
client/src/model/backend/gitlab/digitalTwinConfig/settingsUtility.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import store from 'store/store'; | ||
|
|
||
| /** | ||
| * Non-hook getters for settings stored in the Redux store. | ||
| * | ||
| * - Default values are defined in ./constants.ts | ||
| * - Hook variants are in util/settingsUseHooks.ts | ||
| * - Settings can be overridden by the user in the Settings tab | ||
| */ | ||
| export const getGroupName = (): string => store.getState().settings.GROUP_NAME; | ||
| export const getDTDirectory = (): string => | ||
| store.getState().settings.DT_DIRECTORY; | ||
| export const getCommonLibraryProjectName = (): string => | ||
| store.getState().settings.COMMON_LIBRARY_PROJECT_NAME; | ||
| export const getRunnerTag = (): string => store.getState().settings.RUNNER_TAG; | ||
| export const getBranchName = (): string => | ||
| store.getState().settings.BRANCH_NAME; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this help?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of our tests are slow so this gets rid of the warning.