Skip to content

Conversation

@atomicgamedeveloper
Copy link
Contributor

Copied from previous PR #1083:

Title

Validates client config.

Fixes #658

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Security patch
  • UI/UX improvement

Description

This PR will provide a route to validate the client config file. A comprehensive, manual one for developers, and another one that automatically redirects users in case their config is incorrectly setup or URLs are unreachable.
It will also update the client dependencies. Related to issue #658.

Testing

Manual testing for now.

Impact

  • Zod dependency.
  • Once complete, the website access flow will be different if your config is wrong.
  • LayoutPublic is parameterized with a possible Breakpoint instead of always being 'xs'.
  • Additional route of '/verify'

Additional Information

None.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have added tests for all the new code and any changes made to
    existing code.
  • I have made corresponding changes to the documentation.

atomicgamedeveloper and others added 30 commits December 17, 2024 18:46
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6.
- [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md)
- [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6)

---
updated-dependencies:
- dependency-name: cross-spawn
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.7...3.3.8)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
…n/client/cross-spawn-7.0.6

Bump cross-spawn from 7.0.3 to 7.0.6 in /client
…n/client/nanoid-3.3.8

Bump nanoid from 3.3.7 to 3.3.8 in /client
@prasadtalasila
Copy link
Contributor

@atomicgamedeveloper is this PR complete now for final checks? Thanks.

@atomicgamedeveloper
Copy link
Contributor Author

@atomicgamedeveloper is this PR complete now for final checks? Thanks.

Yes. I have incremented the package version number and tested that the digital twins and added functionality works in the dev setup.

@codecov
Copy link

codecov bot commented Mar 20, 2025

Codecov Report

Attention: Patch coverage is 94.66667% with 8 lines in your changes missing coverage. Please review.

Project coverage is 92.12%. Comparing base (2257ef5) to head (bb74f75).
Report is 4 commits behind head on feature/distributed-demo.

Files with missing lines Patch % Lines
client/src/util/configUtil.ts 93.65% 4 Missing ⚠️
client/src/route/config/Config.tsx 95.65% 2 Missing ⚠️
client/src/route/config/ConfigItems.tsx 93.10% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           feature/distributed-demo    #1181       +/-   ##
=============================================================
+ Coverage                      0.00%   92.12%   +92.12%     
=============================================================
  Files                            15       91       +76     
  Lines                           138     2500     +2362     
  Branches                          6      400      +394     
=============================================================
+ Hits                              0     2303     +2303     
- Misses                          132      194       +62     
+ Partials                          6        3        -3     
Files with missing lines Coverage Δ
client/src/page/LayoutPublic.tsx 100.00% <100.00%> (ø)
client/src/route/auth/Signin.tsx 100.00% <100.00%> (ø)
client/src/routes.tsx 100.00% <100.00%> (ø)
client/src/util/auth/Authentication.ts 100.00% <100.00%> (ø)
client/src/route/config/Config.tsx 95.65% <95.65%> (ø)
client/src/route/config/ConfigItems.tsx 93.10% <93.10%> (ø)
client/src/util/configUtil.ts 93.65% <93.65%> (ø)

... and 98 files with indirect coverage changes

Components Coverage Δ
Website 92.12% <94.96%> (∅)
Lib Microservice ∅ <ø> (∅)
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@prasadtalasila prasadtalasila merged commit 4e17864 into INTO-CPS-Association:feature/distributed-demo Mar 20, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Validate react website configuration

2 participants