Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: check everywhere that Template is on source path of builder #979

Merged
merged 2 commits into from
Nov 17, 2016
Merged

refactor: check everywhere that Template is on source path of builder #979

merged 2 commits into from
Nov 17, 2016

Conversation

pvojtechovsky
Copy link
Collaborator

No description provided.

monperrus
monperrus reviewed Nov 16, 2016
View reviewed changes
src/main/java/spoon/template/Substitution.java
@@ -533,4 +537,40 @@ public static void redirectTypeReferences(CtElement element, CtTypeReference<?>
}
}

static <T> CtClass<T> getTemplateCtClass(CtType<?> targetType, Template<?> template) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc?

monperrus
monperrus reviewed Nov 16, 2016
View reviewed changes
src/main/java/spoon/template/Substitution.java
return getTemplateCtClass(factory, template);
}

static <T> CtClass<T> getTemplateCtClass(Factory factory, Template<?> template) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

javadoc?

@monperrus monperrus merged commit 204d9aa into INRIA:master Nov 17, 2016
@monperrus
Copy link
Collaborator

It seems that you like static methods very much. Why?

@pvojtechovsky
Copy link
Collaborator Author

Do you mean new static getTemplateCtClass in Substitution class? I do not like static. I like when algorithm is implemented only once and there are minimized dependencies. And it is the case now.

@monperrus
Copy link
Collaborator

Do you mean new static |getTemplateCtClass| in Substitution class? I
do not like static. I
OK, we're on the same page. I also think that static methods are bad
future unanticipated reuse with polymorphism and with respect to discovery.

@pvojtechovsky pvojtechovsky deleted the checkTemplateModelExists2 branch November 22, 2016 19:37
@tdurieux tdurieux mentioned this pull request Jan 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monperrus monperrus monperrus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pvojtechovsky @monperrus