Fix #867: perf shadow #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danglotb
force-pushed
the
fix-perf-shadow
branch
3 times, most recently
from
b06e104
to
2a06d46
Compare
monperrus
reviewed
Oct 18, 2016
| return new JavaReflectionTreeBuilder(createFactory()).scan((Class<T>) cl); | ||
| final CtType<T> shadowClass = (CtType<T>) this.shadowCache.get(cl); | ||
| if (shadowClass == null) { | ||
| final CtType<T> newShadowClass = new JavaReflectionTreeBuilder(createFactory()).scan((Class<T>) cl); |
There was a problem hiding this comment.
contract:
shadowCtClass.getFactory().get(shadowCtClass.getActualClass()) == shadowCtClass
danglotb
force-pushed
the
fix-perf-shadow
branch
from
2a06d46
to
4910909
Compare
tdurieux
reviewed
Oct 18, 2016
| if (super.matches(element)) { | ||
| element.setFactory(factory); | ||
| } | ||
| return true; |
There was a problem hiding this comment.
You can simplify by
element.setFactory(factory);
return false; // create an empty list
danglotb
force-pushed
the
fix-perf-shadow
branch
from
4910909
to
b7736a7
Compare
monperrus
reviewed
Oct 24, 2016
| if (shadowClass == null) { | ||
| final CtType<T> newShadowClass = new JavaReflectionTreeBuilder(createFactory()).scan((Class<T>) cl); | ||
| newShadowClass.setFactory(factory); | ||
| newShadowClass.getElements(new TypeFilter<CtElement>(CtElement.class) { |
There was a problem hiding this comment.
use accept instead of getElements
danglotb
force-pushed
the
fix-perf-shadow
branch
from
b7736a7
to
ec75ba8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.