Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

review: build: Add nullaway from uber #5370

Closed
wants to merge 2 commits into from

Conversation

MartinWitt
Copy link
Collaborator

@MartinWitt MartinWitt commented Jul 27, 2023

Adds nullway from uber and set the logging leveling to warning. This currently assumes our packages are correct annotated, which they are not. I disabled all errorprone checks as we don't need two tools checking the same, we only want nullaway.

Adds nullway from uber and set the logging leveling to warning. This currently assumes our packages are correct annotated, which they are not.
@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Jul 27, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@MartinWitt MartinWitt changed the title build: Add nullaway from uber review: build: Add nullaway from uber Jul 27, 2023
@SirYwell
Copy link
Collaborator

example
Example from the CI how the warnings look like.

Is there additional tooling support, e.g. settings to enable in IntelliJ to directly see such warnings?

@MartinWitt
Copy link
Collaborator Author

Sadly the errorprone team is strictly against creating a tool with good useability. The best we have is some community tooling see google/error-prone#444.

@MartinWitt
Copy link
Collaborator Author

As I look more into it, this view is more or less never needed and only required if a person wants to make a PR for nullablility. Qodana will report nullable issues if we add more annotations and has a goood ui.

@MartinWitt
Copy link
Collaborator Author

After a discussion, we concluded that a tool without any usability does not benefit use enough to merge it. We are going forward with Qodana null checks.

@MartinWitt MartinWitt closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants