Skip to content

fix: Qualified name in catch clause resolved incorrectly (noclasspath)#3373

Merged
nharrand merged 3 commits into
INRIA:masterfrom
slarse:issue/3372-qualified-type-in-catch-clause
Jun 14, 2020
Merged

fix: Qualified name in catch clause resolved incorrectly (noclasspath)#3373
nharrand merged 3 commits into
INRIA:masterfrom
slarse:issue/3372-qualified-type-in-catch-clause

Conversation

@slarse

@slarse slarse commented May 16, 2020

Copy link
Copy Markdown
Collaborator

This is a test case to reproduce #3372

I haven't yet had the time to look into solutions.

update fixes #3372

@slarse

slarse commented May 16, 2020

Copy link
Copy Markdown
Collaborator Author

It appears as if using the closest match (if available from TypeBinding.closestMatch(), it's null sometimes) at least lets you resolve the correct readable name. I'll try some stuff with that.

@MartinWitt

Copy link
Copy Markdown
Collaborator

Hi,
if you mark your test with @ignore("UnresolvedBug") the CI will check that the test fails and be green afterwards.

@slarse

slarse commented May 20, 2020

Copy link
Copy Markdown
Collaborator Author

Hi!

Based on the contributing guidelines, I thought that was supposed to be used if you want to submit just a failing test case? I intend to try to solve this problem, I just haven't had the time to look into it yet.

@monperrus monperrus closed this May 23, 2020
@monperrus monperrus reopened this May 23, 2020
@monperrus

monperrus commented Jun 11, 2020

Copy link
Copy Markdown
Collaborator

just pushed a fix to your branch, let's wait for CI

@slarse

slarse commented Jun 13, 2020

Copy link
Copy Markdown
Collaborator Author

@monperrus Looks like it solved the problem? CI failure seems unrelated.

@monperrus monperrus changed the title wip: fix: Qualified name in catch clause resolved incorrectly (noclasspath) fix: Qualified name in catch clause resolved incorrectly (noclasspath) Jun 13, 2020
@monperrus

Copy link
Copy Markdown
Collaborator

unwip-ed, @nharrand ping

@nharrand nharrand merged commit fa343e7 into INRIA:master Jun 14, 2020
@slarse slarse deleted the issue/3372-qualified-type-in-catch-clause branch May 28, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Qualified type references in catch clauses resolved incorrectly (noclasspath)

4 participants