feat(position): CompoundSourcePosition extends SourcePosition #2115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvojtechovsky
force-pushed
the
feaCompoundSrcPos
branch
from
34b6552
to
76c47f4
Compare
|
I assume this is the first one to review before #2113 right? is it ready? |
surli
reviewed
Jun 27, 2018
| import spoon.reflect.cu.SourcePosition; | ||
|
|
||
| /** | ||
| * This interface represents the position of a program element in a source file. |
There was a problem hiding this comment.
The javadoc here is exactly the same that for DeclarationSourcePosition. Could you edit one of those Javadoc to explicit the differences between the interfaces?
yes, I am done here. |
|
API changes: 1 (Detected by Revapi) Old API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-20180627.172809-176 / New API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-SNAPSHOT
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first baby step to fix #2055