feat(launcher): handles range version in MavenLauncher #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
reviewed
Jun 12, 2018
| return versions; | ||
| } | ||
|
|
||
| class Version implements Comparable<Version> { |
There was a problem hiding this comment.
What about extracting the inner classes: the MavenLauncher seems now composed almost entirely of InheritanceModel. It seems easier to me to maintain if it's extracted.
There was a problem hiding this comment.
I don't think it is a good idea InheritanceModel, is completely useless outside MavenLauncher.
I agree that the architecture is not really nice but it is not the purpose of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.