review: feat: Add support to Java 10 'var' keyword #2054
Conversation
surli
changed the title
| @@ -101,7 +101,8 @@ | |||
| OPENED_PACKAGE(MODULE_DIRECTIVE), | |||
| SERVICE_TYPE(MODULE_DIRECTIVE), | |||
| IMPLEMENTATION_TYPE, | |||
| PROVIDED_SERVICE(MODULE_DIRECTIVE); | |||
| PROVIDED_SERVICE(MODULE_DIRECTIVE), | |||
| INFERRED_VARIABLE; | |||
There was a problem hiding this comment.
I propose to name it IS_INFERRED
| @@ -158,6 +161,18 @@ private boolean isNotCandidate(CtMethod<?> candidate) { | |||
| || notCandidates.contains(candidate.getDeclaringType().getSimpleName() + "#" + candidate.getSimpleName()); | |||
| } | |||
|
|
|||
| private boolean hasPrimitiveTypeForParameters(List<CtParameter<?>> parameters) { | |||
There was a problem hiding this comment.
I don't see the relation with this PR. Why was it working before?
There was a problem hiding this comment.
I'm not sure. I suspect that on almost all other setters we were not using primitive types. I can extract it in another PR if you want: the relation here is that it fix a broken test resulting by the new setter.
There was a problem hiding this comment.
Bizarre. We have plenty of other setters with boolean (eg setImplicit, setShadow, etc). It would be much better to understand what happens here.
There was a problem hiding this comment.
Good thing you insisted on that one: I forgot to call the model change listener... I updated the contract here because it was not clear enough.
| @@ -749,6 +749,7 @@ public void testDocumentationContract() throws Exception { | |||
| final Launcher launcher = new Launcher(); | |||
| launcher.getEnvironment().setNoClasspath(true); | |||
| launcher.getEnvironment().setCommentEnabled(true); | |||
| launcher.getEnvironment().setComplianceLevel(10); | |||
There was a problem hiding this comment.
why is this required here?
There was a problem hiding this comment.
I added a new documentation snippet in CtLocalVariable with the following code:
var x = 10;
This won't compile if I do not use a compliance level to 10.
|
API changes: 2 (Detected by Revapi) Old API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-20180619.225448-155 / New API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-SNAPSHOT
|
|
That's great, thanks Simon! |
This PR add the support to Java 10
varkeyword for local type inference.