review feat: add the ability to follow the process of the creation of the Spoon model #2043
Conversation
tdurieux
changed the title
| */ | ||
| public interface SpoonProgress { | ||
|
|
||
| enum PROCESS { |
| * is called when a step in the precess is started | ||
| * @param process the current process | ||
| * @param task the task that has been processed | ||
| * @param taskId the task if |
There was a problem hiding this comment.
I think the end of the comment is missing ;)
|
Is it ready? |
surli
changed the title
| * @param taskId the task id | ||
| * @param nbTask the number of task in the process | ||
| */ | ||
| void step(Process process, String task, int taskId, int nbTask); |
There was a problem hiding this comment.
Am I wrong to say that everywhere in your usage, the task is in fact the filename of the file being processed?
There was a problem hiding this comment.
for the moment it contains only the absolute path of the file.
There was a problem hiding this comment.
So don't you think that the parameter should be renamed then?
There was a problem hiding this comment.
I mean: it's not the task, it's at best a description. The task itself is given by the process parameter.
There was a problem hiding this comment.
it is the task of the process.
| MODEL, | ||
| IMPORT, | ||
| PROCESS, | ||
There was a problem hiding this comment.
I don't see in the diff the usage of PRINT? Shouldn't it used in DJPP?
| @@ -0,0 +1,43 @@ | |||
| package spoon.support.compiler; | |||
There was a problem hiding this comment.
The license header is missing. Could you add it please, else it will break the CI on master: merge with master and mvn license:format
|
API changes: 2 (Detected by Revapi) Old API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-20180616.095904-144 / New API: fr.inria.gforge.spoon:spoon-core:jar:6.3.0-SNAPSHOT
|
fix #1778
I notice with this feature that printing the model is the slowest task.
JTD takes: 4794 ms
Spoon model: 4098 ms
Printing: 5507 ms
It surprised me