-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review fix(mavenlauncher): add support for dependency management of maven #2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not easy to resolve dependencies :/ |
OK for me. Ready for merge? |
not yet |
monperrus
changed the title
fix(mavenlauncher): add support for dependency management of maven
WIP fix(mavenlauncher): add support for dependency management of maven
Jun 3, 2018
then I WIP it |
tdurieux
force-pushed
the
fix-maven-launcher
branch
2 times, most recently
from
June 5, 2018 13:27
5e33983
to
c05521b
Compare
tdurieux
changed the title
WIP fix(mavenlauncher): add support for dependency management of maven
Review fix(mavenlauncher): add support for dependency management of maven
Jun 5, 2018
tdurieux
force-pushed
the
fix-maven-launcher
branch
from
June 5, 2018 13:50
995cc13
to
b9b6ded
Compare
tdurieux
changed the title
Review fix(mavenlauncher): add support for dependency management of maven
WIP fix(mavenlauncher): add support for dependency management of maven
Jun 6, 2018
tdurieux
force-pushed
the
fix-maven-launcher
branch
from
June 6, 2018 14:43
c8adca9
to
6d0d3de
Compare
tdurieux
changed the title
WIP fix(mavenlauncher): add support for dependency management of maven
Review fix(mavenlauncher): add support for dependency management of maven
Jun 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.