test(TemplateMatcher): add tests for named template matchers (uncovered cases) #1092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * | ||
| * returns an appropriate ParameterMatcher defined in a template parameter, or else a default one | ||
| * | ||
| * if a template parameter (field annotated with @Parameter) whose nme (field name) is a substring of the template name, it also works |
| */ | ||
| private ParameterMatcher findParameterMatcher(CtNamedElement templateDeclaration) throws InstantiationException, IllegalAccessException { | ||
| String name = templateDeclaration.getSimpleName(); | ||
| if (templateDeclaration == null) { |
There was a problem hiding this comment.
move the null check one line above
monperrus
force-pushed
the
test-templatematcher
branch
from
6d24350
to
8817731
Compare
|
fixed. @surli ready for merge of you think it's OK.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…