Interface to Exclude Compilation Units From CtModel. #1037
Conversation
| * @return {@code true} if and only if {@code cud} should be excluded, | ||
| * {@code false} otherwise. | ||
| */ | ||
| boolean exclude(final CompilationUnitDeclaration cud, final String path); |
There was a problem hiding this comment.
this is a JDT interface. Ideally, all Spoon interfaces only depend on other Spoon interfaces (good encapsulation). What about changing to CompilationUnit?
There was a problem hiding this comment.
That's why I stored this file in support/compiler/jdt rather than support/compiler/. Changing the parameter cud from CompilationUnitDeclaration to CompilationUnit should be feasible, though.
There was a problem hiding this comment.
On the other hand, doesn't JDTBasedSpoonCompiler.java have to traverse a compilation unit in order to produce a CompilationUnit. That's exactly what I want to avoid here.
There was a problem hiding this comment.
I think removing the first parameter might be the best solution here.
| @@ -413,7 +414,15 @@ protected boolean buildUnitsAndModel(JDTBuilder jdtBuilder, SpoonFolder sourcesF | |||
|
|
|||
| protected void buildModel(CompilationUnitDeclaration[] units) { | |||
| JDTTreeBuilder builder = new JDTTreeBuilder(factory); | |||
| units: | |||
There was a problem hiding this comment.
Can you change the name of the label because it is the same as the parameter. It is confusing.
Ex: unitLoop
|
Is this PR ready to merge or do I miss something? |
|
Thank you for merging. |
|
Thanks for your contribution.
|
fixes #985