Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VirtualFolder.getAllFiles() is slow on MS Windows #916

Closed
pvojtechovsky opened this issue Oct 28, 2016 · 0 comments
Closed

VirtualFolder.getAllFiles() is slow on MS Windows #916

pvojtechovsky opened this issue Oct 28, 2016 · 0 comments

Comments

@pvojtechovsky
Copy link
Collaborator

The call of VirtualFolder.getAllFiles() takes minutes with about 2000 files. Tested on MS Window 10.
It is because it recursively calls List.contains(...), which calls FileSystemFile.equals, which calls slow File.getCanonicalFile()

See PR #915 with test case and fix
sjd78 pushed a commit to sjd78/spoon that referenced this issue Nov 3, 2016
@pvojtechovsky @sjd78
fix(performance): improves performance of VirtualFolder.getAllFiles()…
fb56279 
… and getSubFolders() (closes INRIA#916)
pvojtechovsky added a commit to pvojtechovsky/spoon that referenced this issue Nov 3, 2016
@pvojtechovsky
fix(performance): improves performance of VirtualFolder.getAllFiles()…
8581df3 
… and getSubFolders() (closes INRIA#916)
@tdurieux tdurieux mentioned this issue Jan 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pvojtechovsky