MAINT Changed the use of ColumnTransformer to make_column_transformer #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o column-transformer
ogrisel
approved these changes
May 27, 2025
Collaborator
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
LGTM, I will sync with main and regenerate the notebooks and then merge if all green.
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2025
…ransformer (#831) * changed besides to additionally for better phrasing * Apply suggestions from code review * Changed the use of ColumnTransformer to make_column_transformer * fixed format * fixed format * changed additional mentions of ColumnTransformer * Rerender notebooks --------- Co-authored-by: SebastienMelo <seastien.melo@polytechnique.edu> Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> 6625d0c
ArturoAmorQ
pushed a commit
to ArturoAmorQ/scikit-learn-mooc
that referenced
this pull request
Jun 4, 2025
This was referenced Jun 5, 2025
ArturoAmorQ
added a commit
to ArturoAmorQ/scikit-learn-mooc
that referenced
this pull request
Oct 23, 2025
…INRIA#831) * changed besides to additionally for better phrasing * Apply suggestions from code review * Changed the use of ColumnTransformer to make_column_transformer * fixed format * fixed format * changed additional mentions of ColumnTransformer * Rerender notebooks --------- Co-authored-by: SebastienMelo <seastien.melo@polytechnique.edu> Co-authored-by: Arturo Amor <86408019+ArturoAmorQ@users.noreply.github.com> Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #452, made the use of make_column_transformer more uniform in the MOOC. Since the name of the preprocessors isn't used to modify their parameters, it seems simpler to teach the students to create a ColumnTransformer with the function.