Scoring model as a good practice #464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Comments addressed, thanks! |
ogrisel
reviewed
Dec 10, 2021
Collaborator
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
There are conflicts to solve and in general I think we should add an analysis of the new test scores.
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
ogrisel
reviewed
Dec 14, 2021
Collaborator
ogrisel
left a comment
ogrisel
left a comment
There was a problem hiding this comment.
I think this PR should be split because python_scripts/trees_hyperparameters.py needs more work as explained below while the rest should be good to go with the following small suggestion.
github-actions bot
pushed a commit
that referenced
this pull request
Jan 6, 2022
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com> 2fc9dd3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #444
Though in almost all of the notebooks we score the presented model somehow, there are some exceptions:
On the same line of thought, ensemble_hyperparameters.py computes cv scores for parameter tuning but it doesn't pass the best parameters to a final test-set scoring.
Plotting a validation curve using the train set but no further scoring on the test-set (as in Solution for Exercise M6.03 and Solution for Exercise M6.04) is discussed in this forum post. The former is not addressed in this PR as the AdaBoost notebook will be fixed elsewhere, the latter was solved by computing asking the student to score the model with
n_iter_no_change=5.