Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcode the Digest Sidebar, style fixes for certain widgets therein #89

Merged
merged 3 commits into from
Feb 22, 2020

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Feb 19, 2020

Changes

This pull request makes the following changes:

  • Modifies ENN's sidebar.php to load a custom sidebar partial on the digest category page
  • Adds a sidebar template to output the newly-created Digest Sidebar, or, if that is empty, nothing
  • Registers a Digest Sidebar with appropriate description of where it is employed.

Screen Shot 2020-02-19 at 16 37 27
Screen Shot 2020-02-19 at 16 37 35
Screen Shot 2020-02-19 at 16 41 06

Why

For #86

Testing/Questions

Features that this PR affects:

  • /category/digest/

Questions that need to be answered before merging:

Steps to test this PR:

  1. Check out this branch
  2. In Appearance > Widgets, add some widgets to the Digest Sidebar widget area. I added:
    • a text widget identifying the sidebar
    • a ENN Mailchimp signup widget
    • a textwidget that contains the following:
      <p>
      	Are you subscribed to one or more daily digests? Add or remove subscriptions by following this link:
      </p>
      
      <a class="btn btn-primary" href="https://example.org">Manage Subscription</a>
  3. Visit the following locations:
    • /category/digest/ : the Digest sidebar should be displayed
    • /category/news/ : the Digest sidebar should not be displayed
    • /region/west/ : the Digest sidebar should not be displayed
    • /category/digest/ with a search query: the Digest sidebar should be displayed

@benlk benlk added this to the FRES-011 milestone Feb 19, 2020
@joshdarby
Copy link

@benlk Should we switch the target branch to staging instead of master?

@benlk benlk changed the base branch from master to staging February 19, 2020 22:13
@benlk benlk changed the title Hardcode the Digest Sidebar Hardcode the Digest Sidebar, style fixes for certain widgets therein Feb 20, 2020
@benlk
Copy link
Collaborator Author

benlk commented Feb 20, 2020

See updated widget screenshots in #86.

@benlk benlk merged commit f5eb130 into staging Feb 22, 2020
@benlk
Copy link
Collaborator Author

benlk commented Feb 22, 2020

This is now deployed, but not yet configured with widgets.

@joshdarby
Copy link

I don't actually see this deployed on staging 😕

And I don't have access to their WPE account to be able to deploy it.

@benlk benlk deleted the 86-hardcode-digest-sidebar branch February 28, 2020 20:49
@benlk
Copy link
Collaborator Author

benlk commented Feb 28, 2020

Deployed for real now. Proceeding to config.

@benlk
Copy link
Collaborator Author

benlk commented Feb 28, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants