-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardcode the Digest Sidebar, style fixes for certain widgets therein #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t template partial.
@benlk Should we switch the target branch to |
joshdarby
reviewed
Feb 19, 2020
wp-content/themes/midwestenergynews/partials/sidebar-digest.php
Outdated
Show resolved
Hide resolved
… and Ninja Forms widgets
benlk
changed the title
Hardcode the Digest Sidebar
Hardcode the Digest Sidebar, style fixes for certain widgets therein
Feb 20, 2020
See updated widget screenshots in #86. |
joshdarby
approved these changes
Feb 21, 2020
This is now deployed, but not yet configured with widgets. |
I don't actually see this deployed on staging 😕 And I don't have access to their WPE account to be able to deploy it. |
Deployed for real now. Proceeding to config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request makes the following changes:
sidebar.php
to load a custom sidebar partial on the digest category pageWhy
For #86
Testing/Questions
Features that this PR affects:
Questions that need to be answered before merging:
Steps to test this PR: