-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mypy Pre-Commit Hook for files Pt.2 #661
Add mypy Pre-Commit Hook for files Pt.2 #661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I had some comments but great work so far!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work here, especially with these weird corner cases. I have a few suggestions to fix things, otherwise this looks good!
Co-authored-by: Matthew Bourque <Matthew.Bourque@lasp.colorado.edu>
…sing into add_mypy_files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes. We are ignoring some errors here but I think they are for valid reasons. So looks good to me!
1246b6e
into
IMAP-Science-Operations-Center:dev
Adding the mypy Pre-commit hook for non-instrument files and folders
Overview
Changes for this PR will occur in the
imap_processing
files andimap_processing/cdf
Applying the mypy pre-commit and making any necessary changes to then pass the checks.Please double check all function definitions and the types applied to the parameters.
With any
TODO
listed I tried to explain what error it was causing and then ignored the error in the code line.The places where inline ignore comments are will be changed/fixed before the PR is merged.
New Dependencies
New Files
Deleted Files
Updated Files
-imap_processing/utils.py
-imap_processing/decom.py
-imap_processing/cli.py
-imap_processing/cdf/utils.py
-imap_processing/cdf/imap_cdf_manager.py
-imap_processing/cdf/cdf_attribute_manager.py
Testing