New Ui proposal #30
Open
New Ui proposal #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axios047
commented
Oct 18, 2017
axios047
commented
- Only the html and css have been changed
- Also cannot get the meetup api to work in this version but did not change any code. Currently put a static placeholder.
|
sourabhtk37
reviewed
Oct 18, 2017
|
|
||
| <section class="meetup"> | ||
| <div class="content"> | ||
| <div class="section--next_event"></div> |
There was a problem hiding this comment.
The meetup API is not working because the function is taking the value of the meetup name here. Although it should be hard-coded in the function since the name is fixed.
<div class="section--next_event" data-meetup-group="ILUGDelhi"></div>
There was a problem hiding this comment.
did you fix this @axios047 ? Let's get this merged to master ASAP.
Sincere apologies for not contacting you sooner.
sourabhtk37
reviewed
Oct 18, 2017
| @@ -0,0 +1,21 @@ | |||
| <a href="http://frodo.hserus.net/mailman/listinfo/ilugd" target="_blank" rel=external>Subscribe</a></li> | |||
There was a problem hiding this comment.
This file links.html doesn't seem to be included in the main site.
There was a problem hiding this comment.
Ya. Forgot about that. putting them in.......
There was a problem hiding this comment.
have we progressed any further on this? @axios047
sourabhtk37
reviewed
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.