Skip to content

UI: improve form-rendering#11100

Open
klees wants to merge 1 commit intoILIAS-eLearning:release_10from
klees:10/UI/form_rendering
Open

UI: improve form-rendering#11100
klees wants to merge 1 commit intoILIAS-eLearning:release_10from
klees:10/UI/form_rendering

Conversation

@klees
Copy link
Contributor

@klees klees commented Feb 10, 2026

Hello ILIAS-Community,

this is the result of my last open contract to work on the ILIAS core with you: Make a proposal to solve #43886 and #43899, which requires to improve the general structure of the Forms in the ILIAS-UI-Framework. The contract was budgeted by the ILIAS-Society (thanks @mkunkel and @oliversamoila).

Besides the requirements regarding accessibility, the implementation was guided by these requirements:

  • For every input field there is a common set of "context" that needs to be represented:
    • label
    • byline
    • error message
    • the actual input element from html
  • For every input that context should be as regular as possible:
    • to attach JS as easy as possible
    • to make styling via CSS as easy as possible
    • to make rendering code as simple as possible
    • to allow for easy maintenance of the template and all other code

Please keep in mind that this does not intent to solve each and every accessibility problem in the Forms (or in general ILIAS, of course). Some are carried along from previous versions.

To solve the requirements I had to rewrite and rewire most of the rendering code of the Form, which IMO looks like an improvement in its own right. Also, it should allow to make further improvements more easily. I checked the output regarding HTML-structure and accessibility with the IBM Equal Access Accessibility Checker in version 4.0.12. I'm quite confident that there are no open issues regarding my intended change set, but I might have missed some issues in the swath of other problems that the tool flags on each and every page.

From my POV this is currently good to go to check the new HTML- and code-structure. There are still open tasks, even regarding this change set:

  • styling is broken in many places, it would also be advisable to adjust class names AFAIC
  • some functionality needs to be reconstructed, most prominently the Optional and Switchable Group
  • the unit test currently fail due to the changed HTML output

I don't think that these are worthwhile to work on, though, as far as the HTML structure is not approved by someone.

Please precede with this change set as you see fit.

Kind regards!

@klees klees force-pushed the 10/UI/form_rendering branch from 5d99daa to 2e85156 Compare February 10, 2026 08:39
@thibsy thibsy added bugfix kitchen sink php Pull requests that update Php code javascript Pull requests that update Javascript code css/html Pull requests that propose changes to CSS/SCSS or HTML files. accessibility Pull requests that propose A11Y changes. labels Feb 10, 2026
@klees klees force-pushed the 10/UI/form_rendering branch from 2e85156 to cec7a11 Compare February 10, 2026 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accessibility Pull requests that propose A11Y changes. bugfix css/html Pull requests that propose changes to CSS/SCSS or HTML files. javascript Pull requests that update Javascript code kitchen sink php Pull requests that update Php code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants