UI: improve form-rendering#11100
Open
klees wants to merge 1 commit intoILIAS-eLearning:release_10from
Open
Conversation
5d99daa to
2e85156
Compare
* solves [#43886](https://mantis.ilias.de/view.php?id=43886) and [#43899](https://mantis.ilias.de/view.php?id=43899)
2e85156 to
cec7a11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello ILIAS-Community,
this is the result of my last open contract to work on the ILIAS core with you: Make a proposal to solve #43886 and #43899, which requires to improve the general structure of the Forms in the ILIAS-UI-Framework. The contract was budgeted by the ILIAS-Society (thanks @mkunkel and @oliversamoila).
Besides the requirements regarding accessibility, the implementation was guided by these requirements:
Please keep in mind that this does not intent to solve each and every accessibility problem in the Forms (or in general ILIAS, of course). Some are carried along from previous versions.
To solve the requirements I had to rewrite and rewire most of the rendering code of the Form, which IMO looks like an improvement in its own right. Also, it should allow to make further improvements more easily. I checked the output regarding HTML-structure and accessibility with the IBM Equal Access Accessibility Checker in version 4.0.12. I'm quite confident that there are no open issues regarding my intended change set, but I might have missed some issues in the swath of other problems that the tool flags on each and every page.
From my POV this is currently good to go to check the new HTML- and code-structure. There are still open tasks, even regarding this change set:
I don't think that these are worthwhile to work on, though, as far as the HTML structure is not approved by someone.
Please precede with this change set as you see fit.
Kind regards!