Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed category wise credit calculation #18

Merged
merged 4 commits into from
Sep 16, 2020

Conversation

megatron10
Copy link
Member

@megatron10 megatron10 commented Aug 28, 2020

The older version was under counting credits, since all S grade courses weren't being counted as valid credits. I have updated the code to correctly calculate total and category wise credits, whilst maintaining that the CGPA calculation is done independently (ignoring S graded courses). This is a necessary change as the S graded courses of the previous semester are supposed to count towards total credits. This has no undesirable side effect because of other S graded courses (like NSS/Clean India) as they are in the additional category and are not checked by default, thus aren't factored into the total credit calculation.

Before :-
before

After :-
after

Apart from this the indention has been made uniform.

@megatron10
Copy link
Member Author

@AgamAgarwal @SaiHarshaK

@SaiHarshaK
Copy link
Contributor

More context: Previous semester, we were given a choice to opt for letter grade or choose 'S' for the courses unlike other semesters due to the COVID crisis.
@megatron10 I think you should add "Audit" to the excludeList so that those credits are not added to the total credits count.

@frags51
Copy link
Contributor

frags51 commented Sep 7, 2020

Also mention this clearly in documentation/in the list somewhere? That total credits includes 'S', but not additional. Will save confusion! @megatron10 @SaiHarshaK

@AgamAgarwal AgamAgarwal merged commit f2f887a into IITH:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants