Fixed category wise credit calculation #18
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The older version was under counting credits, since all S grade courses weren't being counted as valid credits. I have updated the code to correctly calculate total and category wise credits, whilst maintaining that the CGPA calculation is done independently (ignoring S graded courses). This is a necessary change as the S graded courses of the previous semester are supposed to count towards total credits. This has no undesirable side effect because of other S graded courses (like NSS/Clean India) as they are in the additional category and are not checked by default, thus aren't factored into the total credit calculation.
Before :-
After :-
Apart from this the indention has been made uniform.