new class L.PortalMarker to incapsulate all portal visual interactions #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 21, 2019 10:10
…visual interactions
`setStyle` is redefined in order to suppress re-render in `highlightPortal` if selected - 3rd re-render avoided too
windows.selectPortal refactored
* `setMarkerStyle` is now method of L.PortalMarker * minor rearrangements
modos189
force-pushed
the
master
branch
3 times, most recently
from
a34b800
to
7b9edd5
Compare
le-jeu
added a commit
to le-jeu/ingress-intel-total-conversion
that referenced
this pull request
Feb 15, 2021
le-jeu
added a commit
to le-jeu/ingress-intel-total-conversion
that referenced
this pull request
Feb 17, 2021
le-jeu
added a commit
to le-jeu/ingress-intel-total-conversion
that referenced
this pull request
Feb 17, 2021
apply/adapt set(Marker)Style PR IITC-CE#251 by johnd0e commit 6201837
le-jeu
added a commit
to le-jeu/ingress-intel-total-conversion
that referenced
this pull request
Feb 17, 2021
apply/adapt set(Marker)Style PR IITC-CE#251 by johnd0e commit 6201837
le-jeu
added a commit
to le-jeu/ingress-intel-total-conversion
that referenced
this pull request
Feb 17, 2021
apply/adapt set(Marker)Style PR IITC-CE#251 by johnd0e commit 6201837
le-jeu
added a commit
to le-jeu/ingress-intel-total-conversion
that referenced
this pull request
May 6, 2021
apply/adapt set(Marker)Style PR IITC-CE#251 by johnd0e commit 6201837
le-jeu
added a commit
to le-jeu/ingress-intel-total-conversion
that referenced
this pull request
Sep 30, 2021
apply/adapt set(Marker)Style PR IITC-CE#251 by johnd0e commit 6201837
le-jeu
added a commit
to le-jeu/ingress-intel-total-conversion
that referenced
this pull request
Jan 8, 2022
apply/adapt set(Marker)Style PR IITC-CE#251 by johnd0e commit 6201837
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L.PortalMarker(todo: document )methods:
setStyle(deprecated, for compatibility with old highlighters)setMarkerStylesetSelectedwindow.createMarkerwindow.setMarkerStylewindow.setPortalIndicatorswindow.selectPortalwindow.portalMarkerScalewindow.getMarkerStyleOptions