New: Add 'accept' header option on validator #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For IIIF services that provide both v2 and v3 manifests at the same URL, the validator needs to send an appropriate 'accept' header to ensure it is returning the appropriate IIIF version response. This PR adds a checkbox to the validator to optionally include an 'Accept' header in the request. The header is set according to the selected IIIF version, which makes it possible to request v3 manifests from a 'default' v2 service, or vice-versa.
|
I think the CI failure is during installation for Python 2.7, and not because of this change. |
|
Thanks Andrew, I’ll have a proper look but I think the python 2.7 issue is due to the version of Pillow. I’ve got a fix in a branch I’m working on to improve the error messages and I’ll merge that first before this so the fix is in the master branch. |
|
I just noticed that this would fix #74 as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For IIIF services that provide both v2 and v3 manifests at the same URL, the validator needs to send an appropriate 'accept' header to ensure it is returning the appropriate IIIF version response.
This PR adds a checkbox to the validator to optionally include an 'Accept' header in the request. The header is set according to the selected IIIF version, which makes it possible to request v3 manifests from a 'default' v2 service, or vice-versa.