-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update API Annex doc references to GeoJSON inclusion, given IIIF NavPlace Extension? #2019
Comments
Yes 👍 I would say deleted, and replaced with a reference to the |
I don't mind doing it! I will look at it tomorrow or the 13th. I can't make the call this Friday 1/14, I will be out 1/14-1/18 but I can have something together for you to look at. Just to confirm, I am 99% sure we are talking about main/source/annex/services/index.md, Section 3 (Services) and more specifically Section 3.2 (GeoJSON). I have a IIIF/API repo fork, I will put a PR together. I'll post back here when it's up and I will let @kirschbombe and the Cookbook know. I agree with @azaroth42. Do we change the icon to ![not allowed] under presentation API, and just have section 3.2 link out to navPlace as the solution for using GeoJSON? Or are we thinking about a complete removal and actually deleting it from the Section 3 table and deleting 3.2, expecting that people will be routed to navPlace when searching for "GeoJSON with IIIF". |
All good questions @thehabes! Is GeoJSON still the service? It's just used in the API via navPlace? If that's the case, I wonder if we should keep "GeoJSON" in the table and replace 3.2 description with info about using navPlace to use the GeoJSON service. |
In Presentation API 3, there is context collision around the Example of Collision {
"id": "http://my.geo.service/GeoJSON/point/12,12/",
"type": ["Feature", "GeoJSONService"],
"properties":{},
"geometry":{
"type":"Point",
"coordinates":[12,12]
}
} In the playground when using the IIIF Presentation 3 context to process this, the "type": [
"https://json-ld.org/playground/Feature",
"https://json-ld.org/playground/GeoJSONService"
] because Presi 3 doesn't process a To make this work, one would have to define "GeoJSONService" in a context file and make sure it scopes in the GeoJSON-LD context, and also make sure that for If you do that properly, then
Of course, one can avoid all of this by using a referenced object in the {
"@context":[
{
"GeoJSONService":{
"@type":"@id",
"@id":"http://my.geo.service/GeoJSON#GeoJSONService"
}
}
],
"id":"http://my.geo.service/GeoJSON/point/12,12/",
"type":"GeoJSONService"
} With |
Since the value for {
"navPlace":{
"id": "http://my.geo.service/GeoJSON/point/12,12/",
"type":"Feature"
}
} |
The draft PR is available at #2089 |
Update: will migrate GeoJson service info to Services page and update the text to say only use with v2, for v3 use navPlace and link to extension |
First pass in draft PR #2092 |
With the potential approval of the NavPlace extension, does the section in the Annex doc on Linking to External Services with a section talking about geojson-ld need to be revised or updated?
The text was updated successfully, but these errors were encountered: