Skip to content

Fix #352 dailybuild rollback error when large number of versionsreplaced #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2021

Conversation

kaicode
Copy link
Member

@kaicode kaicode commented Dec 16, 2021

This fixes the case where somehow the branch documents since the last versioning commit are larger than 100MB. The fix filters the fields of the branch documents when loading a page of them then loads them one by one after filtering so that the 100MB limit is not triggered.

…laced.

This fixes the case where somehow the branch documents since the last versioning commit are larger than 100MB. The fix filters the fields of the branch documents when loading a page of them then loads them one by one after filtering so that the 100MB limit is not triggered.
@kaicode kaicode requested a review from CoderMChu December 16, 2021 14:56
@kaicode
Copy link
Member Author

kaicode commented Dec 16, 2021

Norway have tested this fix and it resolved the issue that they were facing.
They did notice that it took two runs of the scheduled dailybuild import to complete the rollback because of a "branch not found" error on the first run, but this may have been due to a gap in their commit timeline.

Copy link
Member

@CoderMChu CoderMChu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaicode It looks good. Thanks.

NativeSearchQueryBuilder queryBuilder = new NativeSearchQueryBuilder()
.withQuery(boolQuery()
.must(QueryBuilders.termQuery("path", path))
.must(QueryBuilders.rangeQuery("start").gte(timestamp.getTime())))
.withFields("path", "start", "end", "head", "base", "locked")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@CoderMChu CoderMChu merged commit 5e72dbe into develop Dec 17, 2021
@kaicode kaicode deleted the 352-fix branch March 11, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants