FRI-182 Add setAuthorFlag endpoint #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcgihtsdo
commented
Aug 11, 2021
| @@ -19,6 +19,8 @@ | |||
| // Metadata for internal use only and can't be updated via branch metadata REST service | |||
| public static final String INTERNAL_METADATA_KEY = "internal"; | |||
|
|
|||
| public static final String AUTHOR_FLAGS_METADATA_KEY = "authorFlags"; | |||
There was a problem hiding this comment.
BranchMetadataHelper felt like the best location for the new AUTHOR_FLAGS_METADATA_KEY constant.
dmcgihtsdo
commented
Aug 11, 2021
| @@ -131,6 +132,26 @@ public void unlockBranch(@PathVariable String branch) { | |||
| branchService.unlock(branch); | |||
| } | |||
|
|
|||
| @RequestMapping(value = "/branches/{branchPath}/actions/set-author-flag", method = RequestMethod.POST) | |||
| @PreAuthorize("hasPermission('AUTHOR', #branchPath)") | |||
| public BranchPojo setAuthorFlag(@PathVariable String branchPath, @RequestBody SetAuthorFlag setAuthorFlag) { | |||
There was a problem hiding this comment.
This method will receive a key/value and update the Branch's metadata accordingly.
Codecov Report
@@ Coverage Diff @@
## develop #305 +/- ##
=============================================
+ Coverage 66.13% 66.17% +0.03%
- Complexity 3888 3896 +8
=============================================
Files 319 320 +1
Lines 16959 16982 +23
Branches 2315 2316 +1
=============================================
+ Hits 11216 11237 +21
- Misses 4819 4820 +1
- Partials 924 925 +1
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FRI-182 is concerned with adding functionality to allow flags to be associated with Criteria Items.
This feature relies on feature/FRI-182 of AAG.