Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the baseUrl #123

Merged
merged 1 commit into from
May 28, 2020
Merged

Updated the baseUrl #123

merged 1 commit into from
May 28, 2020

Conversation

aHoejen
Copy link
Contributor

@aHoejen aHoejen commented May 28, 2020

I have updated this file to include /fhir in the baseUrl. This is more consistent with the specification and other implementations.

I have updated this file to include /fhir in the baseUrl. This is more consistent with the specification and other implementations.
@kaicode kaicode requested a review from pgwilliams May 28, 2020 09:47
@kaicode
Copy link
Member

kaicode commented May 28, 2020

This looks good to me. Could you take a peek too please @pgwilliams ?

@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #123 into develop will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #123      +/-   ##
=============================================
+ Coverage      64.48%   64.49%   +0.01%     
  Complexity      2785     2785              
=============================================
  Files            265      265              
  Lines          12625    12625              
  Branches        1609     1609              
=============================================
+ Hits            8141     8143       +2     
+ Misses          3802     3801       -1     
+ Partials         682      681       -1     
Impacted Files Coverage Δ Complexity Δ
...services/classification/ClassificationService.java 43.71% <0.00%> (-0.86%) 36.00% <0.00%> (-1.00%)
...d/snowstorm/core/data/services/ConceptService.java 80.86% <0.00%> (-0.29%) 98.00% <0.00%> (-1.00%)
...org/snomed/snowstorm/core/data/domain/Concept.java 81.69% <0.00%> (+1.30%) 74.00% <0.00%> (+1.00%)
...snomed/snowstorm/core/data/domain/Description.java 86.84% <0.00%> (+2.10%) 84.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 048975d...f4fcd0e. Read the comment docs.

@pgwilliams pgwilliams merged commit 9911278 into IHTSDO:develop May 28, 2020
@pgwilliams
Copy link
Member

Yup, looks great, thanks @aHoejen !

Copy link
Member

@pgwilliams pgwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, all good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants