Fix/113 #117
Merged
Fix/113 #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarolopez
force-pushed
the
fix/113
branch
5 times, most recently
from
7fe2968 to
5077ad2
Compare
|
@aidaph I have created in this branch some tests for the Cloud and IP records, we should implement them also for the accelerators and the storage records... |
This was
linked to
issues
May 26, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #117 +/- ##
=========================================
Coverage ? 51.29%
=========================================
Files ? 23
Lines ? 1084
Branches ? 117
=========================================
Hits ? 556
Misses ? 520
Partials ? 8 ☔ View full report in Codecov by Sentry. |
alvarolopez
force-pushed
the
fix/113
branch
4 times, most recently
from
80e054c to
dd230f5
Compare
Fixes: #113 SemVer: bugfix
The `dict` method of the records are, by design, meant to just conver the record to a dictionary, without converting data types. If we want to serialize the records correcty, as we are doing when generating the SSM records, we need to rely on serialization. See [1] for more context. [1]: pydantic/pydantic#5155 (comment) Fixes: #113 SemVer: bugfix
Include missing fields in CloudRecord when being rendered (i.e. remove the `exlude_unset` argument when exporting, and remove versions from rendering. Fixes: #118 SemVer: bufgix
Instead of rendering the individual records in the SSM messenger, the records classes must now implement a `ssm_message` method that provides an export of the mode, with correct serialized values for each field, that the SSM messenger will append to a SSM message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix serialization of fields, using correct method (i.e. JSON serialization always).