Add full path support for the patch operations #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this break existing functionality? |
IEvangelist
requested changes
May 28, 2024
src/Microsoft.Azure.CosmosRepository/Extensions/ExpressionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Extensions/ExpressionExtensions.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Internals/InternalPatchOperation.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Internals/InternalPatchOperation.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Repositories/InMemoryRepository.Update.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Repositories/InMemoryRepository.Update.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Repositories/InMemoryRepository.Update.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Repositories/InMemoryRepository.Update.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Azure.CosmosRepository/Repositories/InMemoryRepository.Update.cs
Outdated
Show resolved
Hide resolved
@IEvangelist In my opinion, it shouldn't. If anyone has used Patch so far, they may have noticed quite quickly that only from the last member of the lambda a path is created. For these people, nothing will change. |
IEvangelist
reviewed
Jun 1, 2024
IEvangelist
reviewed
Jun 1, 2024
mateuszkumpf
force-pushed
the
feature/support-full-path
branch
from
8c5dca8 to
3ec1483
Compare
IEvangelist
approved these changes
Jul 1, 2024
|
@all-contributors please add @mateuszkumpf for code and tests |
|
I've put up a pull request to add @mateuszkumpf! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to propose a new solution to generate a path for Patch operations.
Currently, when a property is selected using a lambda to create a path for a Patch operation, the last property is selected and only the path is created based on that property. (Example: x => x.NestedObject.Property1 creates for us path /property1).
The proposed solution creates a full path for the Patch operation taking into account all the properties that have been selected in the lambda. (Example: x => x.NestedObject.Property1 creates for us path /nestedObject/property1)