Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend HealthChecks to allow AzureCosmosDbHealthCheckOptions t… #418

Merged

Conversation

philip-reed
Copy link
Contributor

Closes #417

Adds an overload to the HealthChecksBuilderExtensions to allow AzureCosmosDbHealthCheckOptions to be provided and bypass assembly scanning to look for IItem container names.

@philip-reed philip-reed changed the title [feat] Extend HealthChecks to allow AzureCosmosDbHealthCheckOptions t… feat: Extend HealthChecks to allow AzureCosmosDbHealthCheckOptions t… Mar 7, 2024
@IEvangelist IEvangelist requested a review from mumby0168 March 7, 2024 13:58
@IEvangelist
Copy link
Owner

Ah, I'm actually seeing a build error:

Error: /home/runner/work/azure-cosmos-dotnet-repository/azure-cosmos-dotnet-repository/src/Microsoft.Azure.CosmosRepository.AspNetCore/Extensions/HealthChecksBuilderExtensions.cs(60,187): error CS1734: XML comment on 'HealthChecksBuilderExtensions.AddCosmosRepository(IHealthChecksBuilder, string?, HealthStatus?, IEnumerable?, TimeSpan?, Func<IServiceProvider, AzureCosmosDbHealthCheckOptions>?)' has a paramref tag for 'AzureCosmosDbHealthCheckOptions', but there is no parameter by that name [/home/runner/work/azure-cosmos-dotnet-repository/azure-cosmos-dotnet-repository/src/Microsoft.Azure.CosmosRepository.AspNetCore/Microsoft.Azure.CosmosRepository.AspNetCore.csproj::TargetFramework=net7.0]
Error: /home/runner/work/azure-cosmos-dotnet-repository/azure-cosmos-dotnet-repository/src/Microsoft.Azure.CosmosRepository.AspNetCore/Extensions/HealthChecksBuilderExtensions.cs(60,187): error CS1734: XML comment on 'HealthChecksBuilderExtensions.AddCosmosRepository(IHealthChecksBuilder, string?, HealthStatus?, IEnumerable?, TimeSpan?, Func<IServiceProvider, AzureCosmosDbHealthCheckOptions>?)' has a paramref tag for 'AzureCosmosDbHealthCheckOptions', but there is no parameter by that name [/home/runner/work/azure-cosmos-dotnet-repository/azure-cosmos-dotnet-repository/src/Microsoft.Azure.CosmosRepository.AspNetCore/Microsoft.Azure.CosmosRepository.AspNetCore.csproj::TargetFramework=net8.0]

@philip-reed
Copy link
Contributor Author

@IEvangelist On it. 👍

@IEvangelist IEvangelist merged commit a99570e into IEvangelist:main Mar 7, 2024
3 checks passed
@philip-reed
Copy link
Contributor Author

@IEvangelist Looks like there's a failed workflow run on main after this was merged, something to do with the docs site.
Is that something you can help with?

https://github.com/IEvangelist/azure-cosmos-dotnet-repository/actions/runs/8189444429

@IEvangelist
Copy link
Owner

I fixed it, thanks though @philip-reed - your changes will be part of the 8.1.4 NuGet, should be live in about 15 mins: https://github.com/IEvangelist/azure-cosmos-dotnet-repository/releases/tag/8.1.4

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HealthCheck Defaults Cannot be overridden
4 participants