Per conversation with Billy, let's remove the release gate for unreli…

.github/workflows/build-validation.yml

@@ -47,57 +47,57 @@ jobs:
         run: |
           dotnet test --no-restore --verbosity normal --filter "Category!=Acceptance"
 
-  acceptance-tests:
-    needs: build
-    runs-on: ubuntu-latest
-
-    steps:
-      - uses: actions/checkout@main
-      - name: Setup .NET
-        uses: actions/setup-dotnet@main
-        with:
-          dotnet-version: |
-            8.0.x
-
-      - name: Install dependencies
-        run: dotnet restore
-
-      - name: Build
-        run: |
-          dotnet build --configuration Release --no-restore
-
-      - name: Prune databases
-        working-directory: ./tools/CosmosTestHelper
-        env:
-          CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
-        run: dotnet run
-
-      - name: Test Functions
-        env:
-          CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
-        run: |
-          dotnet test --no-restore --verbosity normal --filter "Category=Acceptance&Type!=Container&Type!=CosmosEventSourcing"
-
-      - name: Prune databases
-        working-directory: ./tools/CosmosTestHelper
-        env:
-          CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
-        run: dotnet run
-
-      - name: Test Cosmos Event Sourcing
-        env:
-          CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
-        run: |
-          dotnet test --no-restore --verbosity normal --filter "Category=Acceptance&Type=CosmosEventSourcing"
-
-      - name: Prune databases
-        working-directory: ./tools/CosmosTestHelper
-        env:
-          CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
-        run: dotnet run
-
-      - name: Test Container Creation
-        env:
-          CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
-        run: |
-          dotnet test --no-restore --verbosity normal --filter "Category=Acceptance&Type=Container"
+  # acceptance-tests:
+  #   needs: build
+  #   runs-on: ubuntu-latest
+
+  #   steps:
+  #     - uses: actions/checkout@main
+  #     - name: Setup .NET
+  #       uses: actions/setup-dotnet@main
+  #       with:
+  #         dotnet-version: |
+  #           8.0.x
+
+  #     - name: Install dependencies
+  #       run: dotnet restore
+
+  #     - name: Build
+  #       run: |
+  #         dotnet build --configuration Release --no-restore
+
+  #     - name: Prune databases
+  #       working-directory: ./tools/CosmosTestHelper
+  #       env:
+  #         CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
+  #       run: dotnet run
+
+  #     - name: Test Functions
+  #       env:
+  #         CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
+  #       run: |
+  #         dotnet test --no-restore --verbosity normal --filter "Category=Acceptance&Type!=Container&Type!=CosmosEventSourcing"
+
+  #     - name: Prune databases
+  #       working-directory: ./tools/CosmosTestHelper
+  #       env:
+  #         CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
+  #       run: dotnet run
+
+  #     - name: Test Cosmos Event Sourcing
+  #       env:
+  #         CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
+  #       run: |
+  #         dotnet test --no-restore --verbosity normal --filter "Category=Acceptance&Type=CosmosEventSourcing"
+
+  #     - name: Prune databases
+  #       working-directory: ./tools/CosmosTestHelper
+  #       env:
+  #         CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
+  #       run: dotnet run
+
+  #     - name: Test Container Creation
+  #       env:
+  #         CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
+  #       run: |
+  #         dotnet test --no-restore --verbosity normal --filter "Category=Acceptance&Type=Container"

.github/workflows/nuget-publish.yml

@@ -24,61 +24,61 @@ jobs:
         run: |
           dotnet test --no-restore --verbosity normal --filter "Category!=Acceptance"
 
-  acceptance_tests:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@main
-      - name: Setup .NET
-        uses: actions/setup-dotnet@main
-        with:
-          dotnet-version: |
-            8.0.x
-      - name: Install dependencies
-        run: dotnet restore
-
-      - name: Build
-        run: |
-          dotnet build --configuration Release --no-restore
-
-      - name: Prune databases
-        working-directory: ./tools/CosmosTestHelper
-        env:
-          CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
-        run: dotnet run
-
-      - name: Test Functions
-        env:
-          CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
-        run: |
-          dotnet test --no-restore --verbosity normal --filter "Category=Acceptance&Type!=Container&Type!=CosmosEventSourcing"
-
-      - name: Prune databases
-        working-directory: ./tools/CosmosTestHelper
-        env:
-          CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
-        run: dotnet run
-
-      - name: Test Cosmos Event Sourcing
-        env:
-          CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
-        run: |
-          dotnet test --no-restore --verbosity normal --filter "Category=Acceptance&Type=CosmosEventSourcing"
-
-      - name: Prune databases
-        working-directory: ./tools/CosmosTestHelper
-        env:
-          CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
-        run: dotnet run
-
-      - name: Test Container Creation
-        env:
-          CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
-        run: |
-          dotnet test --no-restore --verbosity normal --filter "Category=Acceptance&Type=Container"
+  # acceptance_tests:
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@main
+  #     - name: Setup .NET
+  #       uses: actions/setup-dotnet@main
+  #       with:
+  #         dotnet-version: |
+  #           8.0.x
+  #     - name: Install dependencies
+  #       run: dotnet restore
+
+  #     - name: Build
+  #       run: |
+  #         dotnet build --configuration Release --no-restore
+
+  #     - name: Prune databases
+  #       working-directory: ./tools/CosmosTestHelper
+  #       env:
+  #         CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
+  #       run: dotnet run
+
+  #     - name: Test Functions
+  #       env:
+  #         CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
+  #       run: |
+  #         dotnet test --no-restore --verbosity normal --filter "Category=Acceptance&Type!=Container&Type!=CosmosEventSourcing"
+
+  #     - name: Prune databases
+  #       working-directory: ./tools/CosmosTestHelper
+  #       env:
+  #         CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
+  #       run: dotnet run
+
+  #     - name: Test Cosmos Event Sourcing
+  #       env:
+  #         CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
+  #       run: |
+  #         dotnet test --no-restore --verbosity normal --filter "Category=Acceptance&Type=CosmosEventSourcing"
+
+  #     - name: Prune databases
+  #       working-directory: ./tools/CosmosTestHelper
+  #       env:
+  #         CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
+  #       run: dotnet run
+
+  #     - name: Test Container Creation
+  #       env:
+  #         CosmosConnectionString: ${{ secrets.COSMOS_INTEGRATION_TEST_CONNECTION_STRING }}
+  #       run: |
+  #         dotnet test --no-restore --verbosity normal --filter "Category=Acceptance&Type=Container"
 
   deploy:
     needs:
-      - acceptance_tests
+      # - acceptance_tests
       - unit_tests
     if: github.event.base_ref == 'refs/heads/main'
     runs-on: ubuntu-latest

tests/Microsoft.Azure.CosmosEventSourcingAcceptanceTests/AcceptanceTests.Setup.cs

@@ -114,7 +114,7 @@ public AcceptanceTests(ITestOutputHelper outputHelper)
         _changeFeedService = _provider.GetRequiredService<IChangeFeedService>();
     }
 
-    [Fact]
+    [Fact(Skip = "In discussing this with Bill, we've decided that this might not be reliable enough to justify having it be a release gate.")]
     public async Task CosmosEventSourcingTest()
     {
         ICosmosClientProvider clientProvider =

tests/Microsoft.Azure.CosmosRepositoryAcceptanceTests/ChangeFeed/RatingByCategoryChangeFeedProcessor.cs

@@ -3,18 +3,12 @@
 
 namespace Microsoft.Azure.CosmosRepositoryAcceptanceTests.ChangeFeed;
 
-public class RatingByCategoryChangeFeedProcessor : IItemChangeFeedProcessor<Rating>
+public class RatingByCategoryChangeFeedProcessor(
+    ILogger<RatingByCategoryChangeFeedProcessor> logger,
+    IRepository<RatingByCategory> ratingByCategoryRepository) : IItemChangeFeedProcessor<Rating>
 {
-    private readonly ILogger<RatingByCategoryChangeFeedProcessor> _logger;
-    private readonly IRepository<RatingByCategory> _ratingByCategoryRepository;
-
-    public RatingByCategoryChangeFeedProcessor(
-        ILogger<RatingByCategoryChangeFeedProcessor> logger,
-        IRepository<RatingByCategory> ratingByCategoryRepository)
-    {
-        _logger = logger;
-        _ratingByCategoryRepository = ratingByCategoryRepository;
-    }
+    private readonly ILogger<RatingByCategoryChangeFeedProcessor> _logger = logger;
+    private readonly IRepository<RatingByCategory> _ratingByCategoryRepository = ratingByCategoryRepository;
 
     public async ValueTask HandleAsync(Rating rating, CancellationToken cancellationToken)
     {

tests/Microsoft.Azure.CosmosRepositoryAcceptanceTests/ChangeFeedBasicTests.cs

@@ -43,7 +43,7 @@ public ChangeFeedBasicTests(ITestOutputHelper testOutputHelper) : base(testOutpu
         _changeFeedService = _provider.GetRequiredService<IChangeFeedService>();
     }
 
-    [Fact]
+    [Fact(Skip = "In discussing this with Bill, we've decided that this might not be reliable enough to justify having it be a release gate.")]
     public async Task Create_Rating_For_Product_Is_Replicated_To_Be_Partitioned_By_Category()
     {
         try

tests/Microsoft.Azure.CosmosRepositoryAcceptanceTests/DisabledStrictTypeCheckingTests.cs

@@ -6,16 +6,13 @@ namespace Microsoft.Azure.CosmosRepositoryAcceptanceTests;
 /// <summary>
 /// Required as item options are cached in a static collection, the key is the Type
 /// </summary>
-public class DisabledOffer : Offer
+public class DisabledOffer(string offerType, string createdBy) : Offer(offerType, createdBy)
 {
-    public DisabledOffer(string offerType, string createdBy) : base(offerType, createdBy)
-    {
-    }
 }
 
 [Trait("Category", "Acceptance")]
 [Trait("Type", "Container")]
-public class DisabledStrictTypeCheckingTests : CosmosRepositoryAcceptanceTest
+public class DisabledStrictTypeCheckingTests(ITestOutputHelper testOutputHelper) : CosmosRepositoryAcceptanceTest(testOutputHelper, DisabledStrictTypeCheckingOptions)
 {
     private const string OffersDatabaseName = "offers";
     private const string OffersContainerName = "offers";
@@ -50,7 +47,7 @@ public class DisabledStrictTypeCheckingTests : CosmosRepositoryAcceptanceTest
         });
     };
 
-    [Fact]
+    [Fact(Skip = "In discussing this with Bill, we've decided that this might not be reliable enough to justify having it be a release gate.")]
     public async Task GetAsync_BaseClassSetupWithoutStrictTypeChecking_ReturnSubClassesOnlyDeserializedIntoBaseType()
     {
         try
@@ -88,8 +85,4 @@ public async Task GetAsync_BaseClassSetupWithoutStrictTypeChecking_ReturnSubClas
             await GetClient().UseClientAsync(PruneDatabases);
         }
     }
-
-    public DisabledStrictTypeCheckingTests(ITestOutputHelper testOutputHelper) : base(testOutputHelper, DisabledStrictTypeCheckingOptions)
-    {
-    }
 }