Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp: pagination): pageSizes input width error #931

Merged
merged 1 commit into from
May 30, 2022

Conversation

liuzaijiang
Copy link
Contributor

@liuzaijiang liuzaijiang commented May 26, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

分页组件的pageSizes下拉框宽度有问题,同时select组件option中宣示英文不全

image

image

What is the new behavior?

image

image

Other information

@idux-bot
Copy link

idux-bot bot commented May 26, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #931 (6506826) into main (764529c) will decrease coverage by 0.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
- Coverage   93.38%   92.99%   -0.40%     
==========================================
  Files         678      727      +49     
  Lines       66582    68392    +1810     
  Branches     5872     5892      +20     
==========================================
+ Hits        62179    63599    +1420     
- Misses       4403     4793     +390     
Impacted Files Coverage Δ
packages/components/index.ts 96.38% <0.00%> (ø)
...ges/components/notification/src/useNotification.ts 69.56% <0.00%> (ø)
...ges/components/time-picker/src/TimeRangePicker.tsx 29.41% <0.00%> (ø)
...omponents/time-picker/src/content/RangeContent.tsx 14.48% <0.00%> (ø)
packages/components/textarea/index.ts 100.00% <0.00%> (ø)
...ponents/watermark/src/composables/useCalcBase64.ts 58.13% <0.00%> (ø)
packages/components/statistic/index.ts 100.00% <0.00%> (ø)
packages/components/message/index.ts 96.66% <0.00%> (ø)
packages/components/watermark/src/utils/index.ts 74.07% <0.00%> (ø)
packages/components/cascader/index.ts 100.00% <0.00%> (ø)
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 764529c...6506826. Read the comment docs.

@liuzaijiang liuzaijiang force-pushed the style-pagination-lzj branch 3 times, most recently from b4b589a to afe49d0 Compare May 27, 2022 06:49
@danranVm danranVm merged commit 3e91b33 into IDuxFE:main May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants