Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdk:forms): add option to remove space (#553) #718

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

unknownzjc
Copy link
Contributor

@unknownzjc unknownzjc commented Jan 12, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Control 不支持配置去除首尾的空字符串

What is the new behavior?

  1. ValidatorOptions 增加多一个 trim 的配置控制是否去除首尾字符串
  2. 默认配置不去除首尾字符串

Other information

@idux-bot
Copy link

idux-bot bot commented Jan 12, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #718 (de8f9c9) into main (cfa48ce) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
+ Coverage   85.35%   85.36%   +0.01%     
==========================================
  Files         397      397              
  Lines       10082    10086       +4     
  Branches     2341     2344       +3     
==========================================
+ Hits         8605     8610       +5     
+ Misses       1477     1476       -1     
Impacted Files Coverage Δ
packages/cdk/forms/src/controls.ts 100.00% <100.00%> (ø)
...ponents/image/src/component/ImageViewerContent.tsx 89.65% <0.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfa48ce...de8f9c9. Read the comment docs.

packages/cdk/forms/src/controls.ts Outdated Show resolved Hide resolved
@danranVm danranVm merged commit be43870 into IDuxFE:main Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants