Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk: portal): fix not support html selectors #656

Merged
merged 1 commit into from
Dec 25, 2021

Conversation

liuzaijiang
Copy link
Contributor

@liuzaijiang liuzaijiang commented Dec 23, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

target虽然支持字符串,但是不支持html选择器

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 23, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #656 (d351c1a) into main (598c8b0) will decrease coverage by 0.25%.
The diff coverage is 100.00%.

❗ Current head d351c1a differs from pull request most recent head 65027d3. Consider uploading reports for the commit 65027d3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   83.92%   83.66%   -0.26%     
==========================================
  Files         396      396              
  Lines        9907     9899       -8     
  Branches     2277     2274       -3     
==========================================
- Hits         8314     8282      -32     
- Misses       1593     1617      +24     
Impacted Files Coverage Δ
packages/cdk/portal/src/covertTarget.ts 100.00% <100.00%> (ø)
packages/cdk/scroll/src/utils.ts 53.33% <0.00%> (-32.01%) ⬇️
...ges/cdk/scroll/src/strategy/blockScrollStrategy.ts 84.00% <0.00%> (-2.67%) ⬇️
packages/components/select/src/types.ts 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598c8b0...65027d3. Read the comment docs.

@liuzaijiang liuzaijiang force-pushed the fix-portal-lzj branch 2 times, most recently from f174afc to b48fe3f Compare December 24, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants