Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:*): overlay options update should watch deep #1652

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

overlay的props更新,popper的options有概率不更新

What is the new behavior?

props的监听应当watch deep

Other information

@idux-bot
Copy link

idux-bot bot commented Aug 11, 2023

This preview will be available after the AzureCI is passed.

@sallerli1 sallerli1 force-pushed the fix-overlay-update-props-deep branch from 7cc4b9c to 5b3c3a3 Compare August 11, 2023 09:27
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1652 (08d93ee) into main (97bdafb) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 08d93ee differs from pull request most recent head 5b3c3a3. Consider uploading reports for the commit 5b3c3a3 to get more accurate results

@@            Coverage Diff             @@
##             main    #1652      +/-   ##
==========================================
- Coverage   92.62%   92.62%   -0.01%     
==========================================
  Files         345      345              
  Lines       32199    32198       -1     
  Branches     3677     3675       -2     
==========================================
- Hits        29825    29824       -1     
  Misses       2374     2374              
Files Changed Coverage Δ
...ckages/components/_private/overlay/src/Overlay.tsx 97.87% <100.00%> (-0.01%) ⬇️

@sallerli1 sallerli1 merged commit e6f5fa2 into IDuxFE:main Aug 11, 2023
7 checks passed
@sallerli1 sallerli1 deleted the fix-overlay-update-props-deep branch July 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant