Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(cdk:resize): api docs is incorrect #1607

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

AFine970
Copy link
Contributor

@AFine970 AFine970 commented Jul 19, 2023

开发套件中resize套件文档中api错误

fix #1606

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

Other information

开发套件中resize套件文档中api错误

fix IDuxFE#1606
@idux-bot
Copy link

idux-bot bot commented Jul 19, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #1607 (4d7204c) into main (ab4e4b0) will decrease coverage by 0.20%.
The diff coverage is 86.81%.

❗ Current head 4d7204c differs from pull request most recent head 49fd6fc. Consider uploading reports for the commit 49fd6fc to get more accurate results

@@            Coverage Diff             @@
##             main    #1607      +/-   ##
==========================================
- Coverage   92.76%   92.56%   -0.20%     
==========================================
  Files         332      338       +6     
  Lines       30695    31542     +847     
  Branches     3510     3602      +92     
==========================================
+ Hits        28473    29198     +725     
- Misses       2222     2344     +122     
Impacted Files Coverage Δ
packages/components/icon/src/definitions.ts 100.00% <ø> (ø)
packages/pro/search/src/ProSearch.tsx 19.83% <0.00%> (-0.73%) ⬇️
packages/components/config/src/seerConfig.ts 88.46% <37.50%> (-9.27%) ⬇️
packages/components/icon/src/utils.ts 73.60% <78.57%> (+1.34%) ⬆️
packages/components/text/src/Text.tsx 89.80% <89.80%> (ø)
packages/components/card/src/Card.tsx 99.36% <100.00%> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/icon/src/dependencies.ts 99.12% <100.00%> (-0.05%) ⬇️
packages/components/input/src/Input.tsx 100.00% <100.00%> (ø)
... and 12 more

... and 3 files with indirect coverage changes

@@ -10,15 +10,15 @@
| `boundary` | 可调整尺寸的边界范围 | `'parent' \| 'window' \| Window \| MaybeElementRef` | `parent` | - | - |
| `disabled` | 是否禁用 | `boolean` | `false` | - | - |
| `free` | 是否自由调整 | `boolean` | - | - | 自动设置 `style` |
| `handles` | 定义拖拽手柄的位置 | `ResizableHandlePlacement[]` | `allHandlePlacements` | - | - |
| `handlers` | 定义拖拽手柄的位置 | `ResizableHandlePlacement[]` | `allHandlePlacements` | - | - |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

正确的单词应该是 handles 才对,后面版本可能需要改回来。

@danranVm danranVm merged commit 258ae73 into IDuxFE:main Jul 20, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cdk] 开发套件中resize套件文档中api错误
2 participants