fix(comp:date-picker): disabledDate error on year and month panel #1514
Conversation
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| } | ||
| for (let num = 21; num <= 29; num++) { | ||
| expect(findCell(wrapper, `${num}`)?.classes()).not.toContain('ix-date-panel-cell-disabled') | ||
| } | ||
| }) | ||
|
|
||
| test('month type disabledDate work', async () => { |
There was a problem hiding this comment.
with a code review
The code looks good, the author has done a great job to make the code readable and understandable. However, one improvement suggestion would be to DRY up the code by using a loop in order to test that a range of dates are disabled/enabled. This could be done using a for loop for example, which would iterate over the range of dates and check each date to see if it is enabled or disabled. This would make the code more efficient and readable. Additionally, it would be wise to check the time complexity of the code to ensure that it is running as efficiently as possible.
Overall, the code looks like it is working properly and is easy to read.
| @@ -93,7 +94,7 @@ export default defineComponent({ | |||
| ) | |||
| }) | |||
| const isInRange = computed(() => { | |||
| const compareType = dayTypes.includes(activeType.value) ? 'date' : activeType.value | |||
| const compareType = getPanelCellType(activeType.value) | |||
| const cellDateValue = dateConfig.startOf(cellDate.value, compareType).valueOf() | |||
|
|
|||
| return ( | |||
There was a problem hiding this comment.
with a brief code review:
- The code looks well formatted and organized, which is good.
- There are no obvious bugs in the code.
- The import statement for the getPanelCellDisabled and getPanelCellType functions should be moved to the top of the file so it is easier to find.
- The isDisabled computed property can be simplified by removing the check for !disabledDate and returning the result of getPanelCellDisabled right away.
- The isCurrent computed property should also use getPanelCellType instead of checking the dayTypes array.
- The compareType variable should also use getPanelCellType instead of checking the dayTypes array.
- The labelFormat object could be replaced with an array of objects with the type and format values, this would make it easier to read and maintain.
|
This preview will be available after the AzureCI is passed. |
| } | ||
|
|
||
| return true | ||
| } |
There was a problem hiding this comment.
with a brief code review:
First, the code should be properly indented and spaced for readability.
Second, the code should check for potential errors such as null values or out of bounds errors.
Third, the code should make use of descriptive variable names, commenting and logging to make it easier to understand.
Fourth, the code should be tested to make sure it is performing as expected.
Finally, the code should be optimized for performance. This can include refactoring the code to make it more efficient and using data structures (such as hash tables) to improve lookup time.
Codecov Report
@@ Coverage Diff @@
## main #1514 +/- ##
==========================================
+ Coverage 92.75% 92.78% +0.03%
==========================================
Files 331 332 +1
Lines 30801 30879 +78
Branches 3533 3555 +22
==========================================
+ Hits 28568 28651 +83
+ Misses 2233 2228 -5
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
disabledDate 禁用一个月中的部分日期，整个月或者年都被禁用
What is the new behavior?
重构 disabledDate 算法，计算月、年、季度时，应当考虑中间所有日期的禁用情况
Other information