-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk:popper): upgrade popperjs to floating-ui #1191
feat(cdk:popper): upgrade popperjs to floating-ui #1191
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## next #1191 +/- ##
==========================================
- Coverage 96.95% 93.21% -3.74%
==========================================
Files 318 317 -1
Lines 30137 29932 -205
Branches 2785 3452 +667
==========================================
- Hits 29218 27901 -1317
- Misses 919 2031 +1112
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@@ -37,7 +37,6 @@ export type PopperTrigger = 'click' | 'hover' | 'focus' | 'contextmenu' | 'manua | |||
| `show` | 显示浮层 | `(delay?: number): void` | - | - | `delay` 是延迟显示的时间 | | |||
| `hide` | 隐藏浮层 | `(delay?: number): void` | - | - | `delay` 是延迟隐藏的时间 | | |||
| `update` | 更新浮层 | `(options: Partial<PopperOptions>): void` | - | - | - | | |||
| `forceUpdate` | 强制更新浮层 | `(): void` | - | - | - | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
全局搜一下这个 API , 应该有不少组件有用。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2f657ca
to
0a93d6e
Compare
BREAKING CHANGE: forceUpdate is now removed BREAKING CHANGE: modifiers is now changed to middlewares BREAKING CHANGE: onFirstUpdate is now removed
0a93d6e
to
2f2ca12
Compare
BREAKING CHANGE: modifiers is now changed to middlewares BREAKING CHANGE: forceUpdate is now removed BREAKING CHANGE: onFirstUpdate is now removed
BREAKING CHANGE: forceUpdate is now removed
BREAKING CHANGE: modifiers is now changed to middlewares
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
What is the new behavior?
迁移popperjs到floating-ui/dom
修改overlay的箭头样式
Other information
floating-ui没有生命周期的说法,更新同一都是异步,因此移除forceUpdate
floating-ui的middleware与原先的modifier无法兼容,将modifier改为middleware