Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:table): add scrollToTopOnChange support #1169

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

新增 scrollToTopOnChange 属性配置,支持在分页信息、筛选、排序变更之后滚动到顶部

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 27, 2022

This preview will be available after the AzureCI is passed.

@sallerli1 sallerli1 force-pushed the feat-table-scroll-to-top-saller branch from 1c636ae to df2c293 Compare September 28, 2022 02:15
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #1169 (cda8069) into main (648f832) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head cda8069 differs from pull request most recent head df2c293. Consider uploading reports for the commit df2c293 to get more accurate results

@@           Coverage Diff           @@
##             main    #1169   +/-   ##
=======================================
  Coverage   96.88%   96.89%           
=======================================
  Files         317      317           
  Lines       30670    30682   +12     
  Branches     2800     2802    +2     
=======================================
+ Hits        29715    29729   +14     
+ Misses        955      953    -2     
Impacted Files Coverage Δ
...ages/components/_private/selector/src/Selector.tsx 100.00% <100.00%> (ø)
packages/components/_private/selector/src/token.ts 100.00% <100.00%> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/config/src/types.ts 100.00% <100.00%> (ø)
packages/components/table/src/Table.tsx 100.00% <100.00%> (ø)
packages/components/table/src/types.ts 100.00% <100.00%> (ø)
packages/cdk/scroll/src/utils.ts 80.92% <0.00%> (+1.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 464bf40 into IDuxFE:main Sep 28, 2022
@sallerli1 sallerli1 deleted the feat-table-scroll-to-top-saller branch February 20, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants