fix(comp:textarea): close icon input content is overwritten(#1005) #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #1048 +/- ##
==========================================
- Coverage 93.75% 93.75% -0.01%
==========================================
Files 314 314
Lines 29940 30114 +174
Branches 3542 3553 +11
==========================================
+ Hits 28069 28232 +163
- Misses 1871 1882 +11
Continue to review full report at Codecov.
|
1 task
danranVm
reviewed
Aug 1, 2022
| @@ -110,6 +111,10 @@ describe('Textarea', () => { | |||
|
|
|||
| expect(wrapper.find('.ix-textarea-suffix-hidden').exists()).toBe(false) | |||
|
|
|||
| const res = (renderSuffixFn(true, undefined, '', true, onClear, '', true)?.props as { class: '' }).class | |||
| @@ -74,6 +85,19 @@ export default defineComponent({ | |||
|
|
|||
| useAutoRows(elementRef as Ref<HTMLTextAreaElement>, autoRows, accessor) | |||
|
|
|||
| watch( | |||
There was a problem hiding this comment.
这里更好的方案，不应该去监听是否存在滚动条。
应该是当存在 suffix 的时候，给一个更大的 padding 会更好？参考 input.
|
发现好几个组件都存在这个问题，这个我来修复吧。 |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
close icon overwrites the text
What is the new behavior?
will not overwrite the text
Other information