Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[comp: comment] add comment component #358

Closed
1 task
lionnnnn opened this issue Jul 5, 2021 · 4 comments · Fixed by #822
Closed
1 task

[comp: comment] add comment component #358

lionnnnn opened this issue Jul 5, 2021 · 4 comments · Fixed by #822
Assignees

Comments

@lionnnnn
Copy link
Contributor

lionnnnn commented Jul 5, 2021

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

What does the proposed API look like?

@thinkingOfBetty
Copy link
Contributor

我可以尝试来完成这个组件。

@danranVm danranVm assigned thinkingOfBetty and unassigned lionnnnn Feb 16, 2022
@thinkingOfBetty
Copy link
Contributor

thinkingOfBetty commented Feb 17, 2022

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?
支持设置评论内容下方操作项列表
支持设置评论作者名字、头像
支持展示嵌套的评论
支持设置展示的内容
支持设置评论的时间描述

What does the proposed API look like?

CommentProps

属性 说明 类型 默认值 全局配置 备注
actions 在评论内容下面呈现的操作项列表 ActionButtonProps[] | #actions - - -
author 评论作者名字的元素 string | #author - - -
avatar 评论头像的元素 string | CommentAvatar | #avatar - - -
content 评论的主要内容 string | #content - - -
datetime 展示时间描述 string | #datetime - - -

CommentSlots

名称 说明 参数类型 备注
default 嵌套评论的子项 - -

@danranVm
Copy link
Member

danranVm commented Feb 17, 2022

@thinkingOfBetty 有两个小问题。

  • actions 的类型应该是数组?
  • children 应该是 #default, 另外它应该单独写到 CommentSlots 里去,而不是在 CommentProps 中。

@thinkingOfBetty
Copy link
Contributor

@thinkingOfBetty 有两个小问题。

  • actions 的类型应该是数组?
  • children 应该是 #default, 另外它应该单独写到 CommentSlots 里去,而不是在 CommentProps 中。

是的,这里actions是数组,已经进行修改

thinkingOfBetty added a commit to thinkingOfBetty/idux that referenced this issue Mar 24, 2022
thinkingOfBetty added a commit to thinkingOfBetty/idux that referenced this issue Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants