Skip to content

Conversation

@utkarsh14
Copy link
Collaborator

@utkarsh14 utkarsh14 commented Jun 4, 2025

Targets UX changes

Ticket

Fixes: No tickets created

Description, Motivation and Context

Target UX changes listed on UX discussion page:

  • Fix Error warning table
  • Allow column selection for bulk edits in edit drawer
  • Allow uploading targets when source is surveycto
  • Change all button to custom buttons
  • Disable buttons instead of hiding them on Header Bar
  • Made a common error table component

Assignments:

  • Add blank filters for null or blank values

How Has This Been Tested?

UI Changes

image image image

To-do before merge

  • Fix blank filters bug for assignment location columns

Checklist:

This checklist is a useful reminder of small things that can easily be forgotten.
Put an x in all the items that apply and remove any items that are not relevant to this PR.

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts
  • I have updated the automated tests (if applicable)
  • I have written [good commit messages][1]
  • I have updated the README file (if applicable)
  • I have updated affected documentation (if applicable)

utkarsh14 added 3 commits June 4, 2025 18:26
Fixed error warning tables
Added blank filters to Assignments
@utkarsh14 utkarsh14 requested a review from jeenut27 June 11, 2025 06:31
Copy link
Collaborator

@jeenut27 jeenut27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Remove 'Edit SCTO column mapping' button when target source is csv
  2. Edit button when disabled is turning to blue color on hover
  3. On Edit drawers, can cancel always be on left and save on right. Cancel should be a white colored button
  4. On both edit and bulk edit save the page refreshes and the drawer opens for a second before closing: https://jam.dev/c/8a712e69-899e-401c-bb63-e0818476a092
  5. Check why the target table is shifted to the top for a second before the data gets populated: https://jam.dev/c/983abf41-6199-41ee-a971-05443e405c01
  6. Add targets in append mode is showing a heading and steps copy which is not in the overwrite mode. We can remove the extrac copy: https://jam.dev/c/6fab311b-6a4a-4aa9-8f8c-3e91bc01c55d
  7. Can you check why for SS E2E test the page looks like this:
    error
  8. Can you fix this hover behaviour: https://jam.dev/c/c54fc425-4c22-4f4a-8c15-39dd89b8aad4. Also rename the buttons to Save instead of Save Config. Change button text to Sentence case like 'Change target configuration' - I think we did sentence case in the initial pages like on questions mapping page.

@utkarsh14
Copy link
Collaborator Author

Added assignment filters and fixed assignment filter clear bug

Copy link
Collaborator

@jeenut27 jeenut27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@utkarsh14 utkarsh14 merged commit eb71044 into dev Jun 16, 2025
3 checks passed
@utkarsh14 utkarsh14 deleted the targets_ux branch June 16, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants