Skip to content

Conversation

@utkarsh14
Copy link
Collaborator

@utkarsh14 utkarsh14 commented Mar 25, 2025

SS-2047: Duplicate survey status or survey status label

Ticket

Fixes: https://idinsight.atlassian.net/browse/SS-2047

Description, Motivation and Context

When adding a new survey status with a duplicate survey status or survey status label the code was dispatching the put request.
Fixed the error by using a for loop instead of for each and added a validation to check if put request has any response or not.

How Has This Been Tested?

Local

Checklist:

This checklist is a useful reminder of small things that can easily be forgotten.
Put an x in all the items that apply and remove any items that are not relevant to this PR.

  • My code follows the style guidelines of this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts
  • I have written [good commit messages][1]

@utkarsh14 utkarsh14 requested a review from jeenut27 March 25, 2025 10:51
Copy link
Collaborator

@jeenut27 jeenut27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good!

@utkarsh14 utkarsh14 merged commit 9463cec into dev Mar 26, 2025
3 checks passed
@utkarsh14 utkarsh14 deleted the target_status_bugfix branch March 26, 2025 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants