Ss 1436 #148
Merged
Ss 1436 #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- exclude custom_fields from list of available columns on enumerators - add global redux setMappingErrorCount for enumerators and use it to show no of errors on remap - add loading screen on remap to allow all fields to load before rendering form - eliminate additional fields on targets column mapping setup - redirect to targets upload on targets home if no targets exist - set columns available using column_mapping data from targets list - use global redux to set errors and error count on targets remap upload - add loading screen for targets remap screen to allow all fields to render before showing form - upload data using the merge mode on targets reupload - display columns set by column_mapping as available columns on the reupload screen for targets - add mappingErrorCount to enumerators slice - update target mapping type mode to contain merge
- use screen mode changes to check and reload data on the manage screen
- update routes for UserRoles - remove field supervisor roles , the flow will now use users and role management flow - rename redux for field supervisor roles to user roles - update survey configuration list to remove web app users - create new module for user roles - create screens for add, manage, edit roles - create screens for add, manage, edit users -
- add complete registration flow -
- add a permissions table component - transform permissions data from the backend to display on permissions table - use permissions component on roles add - add redux functionality to fetch all permissions
- clean up the roles list component - use permissions component to display permissions on roles edit and roles add components - rename redux use on the users component
- update permissions table use global state to manage rolePermissions - remove unused code on the roles component - update add roles to validate form data and submit - update user urls on user management api service - add RolePermissions type - add rolePermissions to userRoles redux state
- reset setRolePermissions before add new role - append previous roles to role before adding new roles - add permissions to SupervisorRole type
- update routes for edit role - set permissions data before edit - remove path from add and edit since it is not used - update edit roles component to remove unused imports, functions - update functionality to submit roles data on edit - fix getAllPermissions slice to stop updating roles redux on fetch
- add duplicate role feature - update edit role component to handle role duplication by adding a new role with the same permissions - add duplicate to role permissions request to determine if role is duplicate -
- add modal logic to delete roles - delete roles by using update post for roles
- refactor userRoles to SurveyRoles to avoid confusion with general user management components - add functionality to add / update existing users when adding them to a survey - update user lists to display role names and survey names - add update user redux functionality -
- update edit survey user component to allow role updates - update survey users list component to set edit user data while editing user data - update user management redux to handle edit user data
- update user roles per survey - use user management is loading redux state on user pages - attempt to handle existing roles when user exists - update add user for user management to allow adding super admin users - update manage users on user management to not show roles data if empty
- handle update for multiple roles on add and edit user flows
- handle super admin updates for existing users - add edit user component for user management
- add super admins to existing users on survey management on edit and add flow - add survey admin edit flow - add logic to show existing roles on both add and edit flows for user management -
- add user supervisor logic to both edit and add user flows on survey user management - add user hierarchy api functions - update redux to handle user hierarchy
- add logic on survey users to remove user from project using a delete flow
- update menage users to remove users from the system, also allow multiple removals - add api and redux functions for deleting users
- set supervisor not required on user edit
- update to use survey-roles , survey-users for roles and users respectively - remove useRoles module since module was renamed to surveyUserRoles - update survey configuration updates - rename styling file to SurveyUserRoles - rename manage components to manage--- -
- remove required checks on has_reporting_role on edit/ add roles - filter supervisor users based on the roles - update to handle duplicate roles during update - handle empty roles list - on add user handle super admin / survey admin updates - remove disabled on last_name; first_name to handle users with null values edit - list Super Admin , Survey Admin on the roles list -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[SS-##]
Provide a short, concise and meaningful PR title above. Examples of good PR titles:
"[#TicketID] Feature: add so-and-so feature"
"[#TicketID] Fix: fix abc bug"
Ticket
Fixes: https://idinsight.atlassian.net/browse/SS-##
Description, Motivation and Context
How Has This Been Tested?
UI Changes
To-do before merge
(Optional -- remove this section if not needed)
Include any notes about things that need to happen before this PR is merged, e.g.:
Checklist:
This checklist is a useful reminder of small things that can easily be forgotten.
Put an
xin all the items that apply and remove any items that are not relevant to this PR.