Skip to content

Conversation

@utkarsh14
Copy link
Collaborator

@utkarsh14 utkarsh14 commented Jul 29, 2025

[BUGFIX] Replace null values by blanks

Ticket

Fixes: No tickets created

Description, Motivation and Context

We allowed null values to be uploaded in PR. Null values are kept as NaN in the data frame, which gets passed on to JSON syntax when uploading data. NaN values are invalid for postgres JSON columns.

Replaced NaN values with blanks to fix this.

Also fixed syntax error on enumerator column configs

How Has This Been Tested?

Local

Checklist:

This checklist is a useful reminder of small things that can easily be forgotten.
Put an x in all the items that apply and remove any items that are not relevant to this PR.

  • My code follows the style guidelines and standard practices for this project
  • I have reviewed my own code to ensure good quality
  • I have tested the functionality of my code to ensure it works as intended
  • I have resolved merge conflicts
  • I have written good commit messages
  • I have created migration scripts from the latest dev changes. This will prevent migration script version conflicts (if applicable)
  • I have scrutinized and edited the migration script with reference to changes Alembic won't auto-detect (if applicable). Note that this includes manually adding the creation of new CHECK constraints.
  • I have updated the automated tests (if applicable)
  • I have updated the README file (if applicable)
  • I have updated the OpenAPI documentation (if applicable)

@utkarsh14 utkarsh14 merged commit 8ea9bf7 into dev Jul 31, 2025
5 checks passed
utkarsh14 added a commit that referenced this pull request Aug 1, 2025
* HOTFIX: Fix choice name linking with question name (#290)

* upgrading gevent version

* Add debugging statement for notifications test

* Locations : Set error messages similar to targets/enumerators end point (#321)

* Locations : Set error messages similar to targets/enumerators end point

* Add allow_null_values to target column config

* Add allow null values column in Enumerators column config

* Add summary and invalid records to location upload errors

* Replace null values by blanks (#322)

---------

Co-authored-by: Griffin Muteti <griffinmuteti31@gmail.com>
Co-authored-by: Jayprakash <0freerunning@gmail.com>
Co-authored-by: Jeenu Thomas <jeenu.thomas@idinsight.org>
Co-authored-by: jeenut27 <jeenuthomas27@gmail.com>
@utkarsh14 utkarsh14 deleted the null_values_fix branch August 1, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants