Skip to content

Update to net6.0#3

Merged
IDCs merged 6 commits into
IDCs:masterfrom
abheekda1:net-6.0-update
Mar 16, 2022
Merged

Update to net6.0#3
IDCs merged 6 commits into
IDCs:masterfrom
abheekda1:net-6.0-update

Conversation

@abheekda1
Copy link
Copy Markdown

I used the upgrade assistant along with some manual changes and it compiles with no errors and no warnings and seems to be functional. More testing may need to be done but for now it seems to be working.

Earlier it was attempting to find a file by the name of the URL
@abheekda1 abheekda1 marked this pull request as draft February 1, 2022 04:32
@abheekda1
Copy link
Copy Markdown
Author

Note: it isn't launching after finding the EXEs for the tools, it just hangs.

@abheekda1
Copy link
Copy Markdown
Author

Seems the issue comes during the loading of the main form -- the conflict tree specifically. See if I can figure some stuff out regarding that.

Comment thread WitcherScriptMerger.backup/Controls/SMTree.cs Outdated
@abheekda1 abheekda1 marked this pull request as ready for review February 27, 2022 08:38
@abheekda1
Copy link
Copy Markdown
Author

@IDCs I think this should be fully functional now and I also think that it would be worth it to update to net6.0.

@IDCs
Copy link
Copy Markdown
Owner

IDCs commented Mar 16, 2022

Sorry it took so long to review your changes - looks good thank you for your contribution!

Going to release this once I make the necessary changes to the Vortex extension so that it can pull it and configure it automatically.

@IDCs IDCs merged commit 6ccd212 into IDCs:master Mar 16, 2022
@abheekda1
Copy link
Copy Markdown
Author

Sounds great! I'd like to get the script merger as up-to-date as possible so I might be making some more PRs in the future. Thanks for taking a look and merging it!

@abheekda1 abheekda1 deleted the net-6.0-update branch March 16, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants