Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip empty dataframes to avoid runtime error #446

Merged
merged 5 commits into from
Sep 15, 2022

Conversation

Takadonet
Copy link
Contributor

To address issue #445

@arnauqb
Copy link
Member

arnauqb commented Sep 15, 2022

Oh! you've been faster than me haha. I have removed dash from the requirements since we no longer use it. So just doing this https://github.com/IDAS-Durham/JUNE/pull/447/files should be enough

@Takadonet
Copy link
Contributor Author

rebased. Should be good to test again :)

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #446 (c3f904d) into master (340ebd4) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #446      +/-   ##
==========================================
- Coverage   91.59%   91.58%   -0.02%     
==========================================
  Files         188      188              
  Lines       17624    17626       +2     
==========================================
  Hits        16142    16142              
- Misses       1482     1484       +2     
Impacted Files Coverage Δ
june/records/records_writer.py 74.74% <0.00%> (-0.52%) ⬇️
june/distributors/school_distributor.py 86.06% <0.00%> (ø)

@arnauqb arnauqb merged commit 33c20a4 into IDAS-Durham:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants